perf(Core): Reduce empty array allocations further#873
Merged
Conversation
Similar to fsprojects#851 Calling Array.collect with an empty array results in the allocation of one zero length single dimensional array and one zero length two dimensional array, and as this function is called with huge frequency, this results in a substantial number of allocations. The early exit also seems to avoid the allocation of a lambda in the empty case, reducing allocations further. Benchmarks: Before: | Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated | |--------------- |---------:|--------:|--------:|-----------:|----------:|----------:|----------:| | LintParsedFile | 845.7 ms | 6.99 ms | 6.19 ms | 20000.0000 | 7000.0000 | 1000.0000 | 325.1 MB | After | Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated | |--------------- |---------:|--------:|--------:|-----------:|----------:|----------:|----------:| | LintParsedFile | 817.4 ms | 4.79 ms | 4.25 ms | 14000.0000 | 5000.0000 | 1000.0000 | 229.87 MB |
Contributor
Author
Numpsy
marked this pull request as ready for review
July 19, 2026 17:12
Collaborator
|
Thanks @Numpsy ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Similar to #851
Calling Array.collect with an empty array results in the allocation of one zero length single dimensional array and one zero length two dimensional array, and as this function is called with huge frequency, this results in a substantial number of allocations.
The early exit also seems to avoid the allocation of a lambda in the empty case, reducing allocations further.
Benchmarks:
Before:
After