Skip to content

refactor: the Tuple and Option modules of FlatList call the default module by its short name #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xperiandri wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: the Tuple and Option modules of FlatList call the default module by its short name #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/FSharp.Collections.Immutable/FlatList/FlatListOption.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ let tryItem index (array : FlatList<'T>) = Array.tryItem index (unwrapArray (nam
let tryLast (array : FlatList<'T>) = Array.tryLast (unwrapArray (nameof array) array)

[<CompiledName "TryTail">]
let tryTail (array : FlatList<'T>) =
FSharp.Collections.Immutable.FlatList.tryTail array
|> ValueOption.toOption
let tryTail (array : FlatList<'T>) = FlatList.tryTail array |> ValueOption.toOption

// ---- Search ----

Expand Down
12 changes: 6 additions & 6 deletions src/FSharp.Collections.Immutable/FlatList/FlatListTuple.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ let unfold (generator : 'State -> ('T * 'State) voption) (state : 'State) =
| ValueSome (item, next) -> ValueSome (struct (item, next))
| ValueNone -> ValueNone

FSharp.Collections.Immutable.FlatList.unfold generateStruct state
FlatList.unfold generateStruct state

// ---- Transformation ----

Expand Down Expand Up @@ -72,7 +72,7 @@ let mapFold (mapping : 'State -> 'T -> 'Result * 'State) (state : 'State) (array
let result, next = mapping state item
struct (result, next)

let struct (results, final) = FSharp.Collections.Immutable.FlatList.mapFold mapStruct state array
let struct (results, final) = FlatList.mapFold mapStruct state array
results, final

[<CompiledName "MapFoldBack">]
Expand All @@ -81,7 +81,7 @@ let mapFoldBack (mapping : 'T -> 'State -> 'Result * 'State) (array : FlatList<'
let result, next = mapping item state
struct (result, next)

let struct (results, final) = FSharp.Collections.Immutable.FlatList.mapFoldBack mapStruct array state
let struct (results, final) = FlatList.mapFoldBack mapStruct array state
results, final

// ---- Partitioning and grouping ----
Expand All @@ -98,17 +98,17 @@ let groupBy (projection : 'T -> 'Key) (array : FlatList<'T>) =

[<CompiledName "Partition">]
let partition predicate (array : FlatList<'T>) =
let struct (accepted, rejected) = FSharp.Collections.Immutable.FlatList.partition predicate array
let struct (accepted, rejected) = FlatList.partition predicate array
accepted, rejected

[<CompiledName "PartitionWith">]
let partitionWith (partitioner : 'T -> Choice<'T1, 'T2>) (array : FlatList<'T>) =
let struct (first, second) = FSharp.Collections.Immutable.FlatList.partitionWith partitioner array
let struct (first, second) = FlatList.partitionWith partitioner array
first, second

[<CompiledName "SplitAt">]
let splitAt index (array : FlatList<'T>) =
let struct (before, after) = FSharp.Collections.Immutable.FlatList.splitAt index array
let struct (before, after) = FlatList.splitAt index array
before, after

// As in the module above: the functions that build a tuple per element share their algorithm with the default module,
Expand Down
Loading