Add F# LINQ expression translation pipeline for Cosmos queries (quotations, pipes/composition, options)#19
Draft
Copilot wants to merge 10 commits into
Draft
Add F# LINQ expression translation pipeline for Cosmos queries (quotations, pipes/composition, options)#19Copilot wants to merge 10 commits into
Copilot wants to merge 10 commits into
Conversation
* Added detailed project overview, solution structure, library list, and comprehensive F# coding guidelines. * Included language preferences, nullable reference type handling, class instantiation rules, extension member patterns, naming conventions, and testing requirements. * Replaced previous brief instructions with a thorough, structured guide.
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/f54b9af5-58b9-43dd-b924-82ebb5660dbe Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
…guards Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/f54b9af5-58b9-43dd-b924-82ebb5660dbe Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement LINQ translation methods for F# constructs
Add F# LINQ expression translation pipeline for Cosmos queries (quotations, pipes/composition, options)
May 23, 2026
xperiandri
reviewed
May 24, 2026
Comment on lines
+32
to
+35
| Assert.IsFalse ( | ||
| translatedText.Contains ("op_ComposeRight", StringComparison.Ordinal), | ||
| $"Composition operators should be normalized before Cosmos LINQ translation. Actual: {translatedText}" | ||
| ) |
Collaborator
There was a problem hiding this comment.
@copilot StringAssert has overloads with StringComparison.
Author
There was a problem hiding this comment.
StringAssert doesn't have a DoesNotContain method in MSTest 3.8.3 - only Contains, StartsWith, EndsWith, Matches, and DoesNotMatch. For negative string containment checks, the options are:
Assert.IsFalse(str.Contains(x, StringComparison.Ordinal), msg)(current approach)Assert.DoesNotContain(x, str, StringComparison.Ordinal, msg)(has a circular-call bug causing stack overflow in MSTest 3.8.3)
We're using approach #1 to avoid the MSTest bug while still specifying StringComparison.Ordinal for the comparison.
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/62455df9-06a6-437e-9e28-b0d98d37fde2 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
xperiandri
force-pushed
the
main
branch
2 times, most recently
from
4e9ebae to
0eef905
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringAssert.Contains(value, substring, message, comparisonType)overload is present in MSTest 3.8.3StringAssert.Contains(value, substring, message)calls withStringAssert.Contains(value, substring, message, StringComparison.Ordinal)intests/Cosmos.Tests/Tests.fsAssert.IsFalse(str.Contains(X, StringComparison.Ordinal), msg)for negative assertions (MSTest 3.8.3 has a circular-call bug in allAssert.DoesNotContainstring overloads that causes a stack overflow)