chore: Ship [Obsolete] markers on PostProcessResult v7-deprecated overloads#296
Open
dimension-zero wants to merge 1 commit into
Open
chore: Ship [Obsolete] markers on PostProcessResult v7-deprecated overloads#296dimension-zero wants to merge 1 commit into
dimension-zero wants to merge 1 commit into
Conversation
`PostProcessResult`, `PostProcessResults` and `TryPostProcessResult` each carried a `// TODO for V7 [<System.Obsolete(...)>]` comment that was never actioned. Convert the comments into real attributes pointing at the modern replacement names (`GetResult`, `GetResults`, `TryGetResult`). Bodies are unchanged — consumers get a deprecation warning, not a compile error. The existing `#nowarn "44"` at the top of the test file already covers the in-suite usages, so the test build stays clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostProcessResult,PostProcessResultsandTryPostProcessResulteach had a// TODO for V7 [<System.Obsolete(...)>]comment that was never actioned. Convert each into a real[<System.Obsolete>]attribute pointing at the modern replacement (GetResult/GetResults/TryGetResult).Why
The comments were debt: future maintainers had to discover they meant to deprecate these. Bodies remain unchanged so this is non-breaking — downstream consumers will see an FS0044 warning recommending the replacement, but their code still compiles.
The test suite already has
#nowarn "44"at the top ofTests.fs, so the test build stays clean.Test plan
dotnet build -c Release— clean (0 warnings)dotnet test -c Release— 112/112 pass