Repository navigation
Read-only offline dashboard - #658
Merged
Merged
Conversation
The service worker already served cached page HTML offline, but expired it after a day, so most offline launches got the bare offline page. Pages now keep a week (still cleared when the signed-in user changes), and the offline page links to the saved dashboard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QU2jrSHDpWbeLWT9Sv5YyJ
An offline banner across the signed-in app explains the page is as last loaded and that changes need a connection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QU2jrSHDpWbeLWT9Sv5YyJ
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QU2jrSHDpWbeLWT9Sv5YyJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Follow-up to #654–#657. When offline, show the user's last-loaded abode instead of the bare offline page.
d606a67). The service worker already served cached page HTML when offline, but expired it after one day, so most offline launches landed on/~offline. It now keeps pages for 7 days (still max 32 entries, and still cleared when the signed-in user changes). Item images were already cached, so the grid comes back with its covers./dashboard. When that isn't cached either, the offline page simply comes back.6f315ce) across the signed-in app, driven by a newuseIsOnlinehook (useSyncExternalStore, assumed online during SSR). It says the page is as last loaded and that changes need a connection, and it firesoffline_banner_shown.Checklist
offline_banner_showncaptureServerException/ the error boundary, or N/A: N/Aoffline-banner.test.tsx(hidden online; appears and disappears with connectivity; shows on a page loaded offline), the offline page link test, and a storylearnskill, or N/A: N/ANotes
Generated by Claude Code