Various fixes prior to release - #272
Merged
Merged
Conversation
Signed-off-by: samfreund <samf.236@proton.me>
|
🌐 Preview URL: https://pr-272-frcsoftware.frcsoftware.workers.dev |
Signed-off-by: samfreund <samf.236@proton.me>
Signed-off-by: samfreund <samf.236@proton.me>
samfreund
force-pushed
the
various-fixes
branch
from
September 11, 2026 03:43
ca96b6c to
c45ff7e
Compare
…mple code The Stage 1A course content referenced NiDsXboxController while the actual Stage 1A solution code uses XboxController. Standardize on XboxController/ CommandXboxController throughout.
samfreund
force-pushed
the
various-fixes
branch
from
September 11, 2026 04:01
c45ff7e to
742f53e
Compare
samfreund
marked this pull request as ready for review
September 11, 2026 04:02
Contributor
|
1b will need updated sim-gui files for the keyboard control to work properly with |
…1 buttons) The stage1b solution code uses xbox.leftBumper() (button 9), xbox.rightBumper() (button 10), and xbox.a() (button 0) on CommandXboxController. The previous simgui only had 6 buttons, which didn't support the bumper buttons. Updated to 11 buttons with the same key configuration as stage1a.
Adrianamm
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Disclosure: trawled through to find issues. Some changes human, some AI. All reviewed by myself.