fix: make SimpleRotary double-press backspace reliable#405
Draft
fix: make SimpleRotary double-press backspace reliable#405
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Memory usage change @ 2f114dd
Click for full report table
Click for full report CSV |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/input/SimpleRotaryAdapter.h`:
- Around line 18-22: The comment hardcodes "500ms" but the actual minimum is
computed from SIMPLE_ROTARY_BUTTON_DEBOUNCE_DELAY; update the documentation in
SimpleRotaryAdapter.h to avoid the magic number and instead reference the
computed minimum (e.g., "the minimum is computed from
SIMPLE_ROTARY_BUTTON_DEBOUNCE_DELAY") and/or show the expression used to compute
it so the comment remains correct if SIMPLE_ROTARY_BUTTON_DEBOUNCE_DELAY is
changed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 72281e3b-874a-44d6-a0c3-9fb1ebc77767
📒 Files selected for processing (4)
examples/ButtonWithRotaryAdapter/ButtonWithRotaryAdapter.inoexamples/InputRotary/InputRotary.inoexamples/SimpleRotary/SimpleRotary.inosrc/input/SimpleRotaryAdapter.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimpleRotaryAdapteruse an effective double-press threshold that is reliable with SimpleRotary's 200ms button sampling.DOUBLE_PRESS_THRESHOLD=0behavior for disabling double-press, while clamping positive values below the minimum to avoid missed BACKSPACE actions.Testing
pio ci -b esp32dev -l . -O platform=espressif32 -O framework=arduino -O $'lib_deps=\nmarcoschwartz/LiquidCrystal_I2C@^1.1.4\narduino-libraries/LiquidCrystal@^1.0.7\nmprograms/SimpleRotary@^1.1.3\nmadleech/Button@^1.0.0' examples/InputRotary/InputRotary.inopio ci -b esp32dev -l . -O platform=espressif32 -O framework=arduino -O $'lib_deps=\nmarcoschwartz/LiquidCrystal_I2C@^1.1.4\narduino-libraries/LiquidCrystal@^1.0.7\nmprograms/SimpleRotary@^1.1.3\nmadleech/Button@^1.0.0' examples/SimpleRotary/SimpleRotary.inopio ci -b esp32dev -l . -O platform=espressif32 -O framework=arduino -O $'lib_deps=\nmarcoschwartz/LiquidCrystal_I2C@^1.1.4\narduino-libraries/LiquidCrystal@^1.0.7\nmprograms/SimpleRotary@^1.1.3\nmadleech/Button@^1.0.0' examples/ButtonWithRotaryAdapter/ButtonWithRotaryAdapter.inoIssue
Summary by CodeRabbit
Documentation
Bug Fixes
DOUBLE_PRESS_THRESHOLDto 0.