Skip to content

e2e: create the harness's test users as Roles only, so the rbac and group tests pass again #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schmitch merged 1 commit into from
Nov 2, 2026
Merged

e2e: create the harness's test users as Roles only, so the rbac and group tests pass again #786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/e2e/src/stack.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,13 +981,18 @@ impl TestServer {
/// do (#322): the admin invites it and, with no email service
/// configured, gets the invitation link; the user then chooses
/// `password` (at least 12 characters) from it. Returns its numeric id.
///
/// The account is Roles only (`"role": "roles_only"`): it holds the roles
/// a test assigns and nothing else. `POST /admin/users`' default, Reader,
/// would give it the built-in `reader` role, an unscoped read of every
/// repository that lifts any selector-scoped or missing grant (#785).
pub async fn create_user(&self, username: &str, password: &str) -> i64 {
let (u, p) = self.admin_basic();
let body: serde_json::Value = self
.client()
.post(format!("{}/admin/users", self.base_url))
.basic_auth(&u, Some(&p))
.json(&serde_json::json!({"username": username}))
.json(&serde_json::json!({"username": username, "role": "roles_only"}))
.send()
.await
.unwrap()
Expand Down
Loading