Repository navigation
web-e2e: fill the package delay by its field's own label, so the proxy-delay spec passes again - #783
Merged
Merged
Conversation
Since the package delay overrides (#744), the repository form shows the proxy's delay in a panel titled Package delay, which labels its section. The spec's `getByLabel(/package delay/i)` matched the panel and the seconds field, and Playwright's strict mode refused it, so web-e2e failed on main. The spec now names the field, `Package delay (seconds)`, as RepositoryForm.test.tsx does. Fixes #781 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012e6DJb6V3DHD5wQrsYhKda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #781
What
Since #744 (package delay overrides), the repository form puts a proxy's delay settings in a panel titled Package delay, which labels its
<section>.proxy-delay.spec.tsfilled the field withgetByLabel(/package delay/i), which now matches the panel and thePackage delay (seconds)input both. Playwright's strict mode refused it, soweb-e2efailed onmain(CI run of 1114a17):The spec now names the field,
getByLabel('Package delay (seconds)'), asRepositoryForm.test.tsxdoes. A test-only change, so there is no changelog fragment.Why it blocks 2.2.0
release.ymlneeds a CI run of the tagged commit that passed every job inREQUIRED_JOBS,web-e2eincluded. Together with #780 (e2e), this turnsmaingreen again.Tests
pnpm exec playwright test e2e/specs/proxy-delay.spec.tspasses locally against the built SPA and a realforge-server: 1 passed. I launched it with the sandbox's preinstalled Chromium through a local wrapper config, which is not committed.Generated by Claude Code