feat: support PRD approval via GitHub PR (enhancement proposal flow)#83
Open
ItzikEzra-rh wants to merge 10 commits into
Open
feat: support PRD approval via GitHub PR (enhancement proposal flow)#83ItzikEzra-rh wants to merge 10 commits into
ItzikEzra-rh wants to merge 10 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add create_branch, create_or_update_file, and get_file_contents methods to GitHubClient for PR-based PRD approval workflow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…roval Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… docstring Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace global PRD_APPROVAL_MODE env var with per-project Jira property forge.prd_proposals_repo. When set on a project, enables PR-based PRD approval for that project. Global PRD_PROPOSALS_REPO env var serves as fallback when forge_require_project_config=false. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
In github-pr mode, feedback comes from the PR, not Jira. Jira comments at PRD gates are now skipped when prd_pr_number exists in state. This prevents random Jira comments from triggering unwanted PRD regeneration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Address code review findings: - Move inline ForgeLabel import to module-level (issue forge-sdlc#2) - Store prd_pr_file_path in state at PR creation time and use it directly in _update_prd_proposal_pr, eliminating the fragile directory listing approach (issue forge-sdlc#3) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in mode where PRD review happens on a GitHub PR instead of Jira. Resolves #33.
forge.prd_proposals_repoforge:prd-approvedon Jira, proceeds to spec generationPRD_PROPOSALS_REPOenv var serves as fallback whenforge_require_project_config=falseFiles changed
config.pyprd_proposals_repo,prd_proposals_pathsettingsgithub/client.pycreate_branch,create_or_update_file,get_file_contentsjira/client.pyget_prd_proposals_repoproject property readerfeature/state.pyprd_pr_url,prd_pr_number,prd_pr_repo,prd_pr_branchprd_generation.pyworker.pycomment_classifier.pyCLAUDE.mdDesign decisions
generate_prd, gate routing is already source-agnosticforge.prd_proposals_repoJira project property, matching the existingforge.repospatternTest plan
🤖 Generated with Claude Code