fix: stop publish when agent compilation fails - #337
Open
konkonrong-lgtm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ScriptAgent.publish()recompiles the current AgentScript before publishing,but it previously did not check the returned compilation status. AgentScript
syntax errors are returned as
{ status: "failure", compiledArtifact: null }rather than thrown.
If the
ScriptAgentalready had an artifact cached from an earlier successfulcompilation, publishing continued with that older artifact after the new
compilation failed.
This change stops publishing when compilation fails, clears the cached
artifact, and throws an
AgentCompilationErrorcontaining the compilationdetails.
The regression test reproduces the issue by returning a successful compilation
response followed by a failure response. Before this change,
ScriptAgentPublisher.publishAgentJson()was still called after the failure.Tests:
yarn compileyarn lint— 0 errorsyarn test:only— 407 passing, 1 pendingyarn nyc mocha "test/agents.test.ts"— 26 passing, 1 pendingyarn nyc mocha "test/agentPublisher.test.ts"— 20 passingWhat issues does this PR fix or reference?
N/A