Skip to content

fix: remove add_ons field from sponsor page template popup#934

Merged
smarcet merged 2 commits into
masterfrom
fix/sponsor-page-template-add-on
May 13, 2026
Merged

fix: remove add_ons field from sponsor page template popup#934
smarcet merged 2 commits into
masterfrom
fix/sponsor-page-template-add-on

Conversation

@tomrndom
Copy link
Copy Markdown

@tomrndom tomrndom commented May 13, 2026

  • adjust normalize function

ref: https://app.clickup.com/t/86b9wze7h

Summary by CodeRabbit

  • Bug Fixes
    • Sponsor page template creation now allows users to proceed without selecting add-ons, providing greater flexibility in form submission.

Review Change Stack

…rmalize function

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d12e3c45-9a0a-4f7f-92b9-a26adf00ebf0

📥 Commits

Reviewing files that changed from the base of the PR and between d20c750 and 384fd8f.

📒 Files selected for processing (1)
  • src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/components/add-sponsor-page-template-popup/index.js

📝 Walkthrough

Walkthrough

The sponsor page template popup form validation for the add_ons field was simplified: the schema changed from a custom required non-empty array constraint to plain yup.array(), allowing the form to validate and submit even when no add-ons are selected.

Changes

Relax add-ons validation in sponsor page template popup

Layer / File(s) Summary
Add-ons validation schema relaxation
src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/components/add-sponsor-page-template-popup/index.js
Formik validation for the add_ons field simplified from a required non-empty check to a plain yup.array(), permitting empty selections to pass validation.

Possibly related PRs

  • fntechgit/summit-admin#924: Adjusts Yup validation rules for sponsor-related form fields, including relaxation of add_ons validation in the add template popup.
  • fntechgit/summit-admin#823: Adjusts Formik/Yup handling of the sponsor-template add_ons field, aligning validation behavior across sponsor form and page template components.

Suggested reviewers

  • smarcet

Poem

🐰 A form that once demanded care,
Now breathes with lighter, easier air.
Add-ons optional, validation freed—
The template pops with what it'll need! 📋✨


🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims to 'remove add_ons field' but the actual change only relaxes validation; the field and UI wiring remain present. Update the title to accurately reflect the change, such as 'fix: relax add_ons validation in sponsor page template popup' or 'fix: make add_ons optional in sponsor page template popup'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sponsor-page-template-add-on

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomrndom tomrndom requested a review from smarcet May 13, 2026 12:27
@tomrndom tomrndom marked this pull request as ready for review May 13, 2026 14:59
{openPopup === "usingTemplate" && (
<AddSponsorPageTemplatePopup
sponsor={sponsor}
summitId={currentSummit.id}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomrndom add ?

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Copy link
Copy Markdown

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 2fa3012 into master May 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants