Skip to content

fix: remove reducer case for adding forms using template#929

Merged
smarcet merged 1 commit into
masterfrom
fix/sponsor-form-from-template
May 11, 2026
Merged

fix: remove reducer case for adding forms using template#929
smarcet merged 1 commit into
masterfrom
fix/sponsor-form-from-template

Conversation

@tomrndom
Copy link
Copy Markdown

@tomrndom tomrndom commented May 11, 2026

ref: https://app.clickup.com/t/86b9v3d4u

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

Refactor

  • Simplified managed forms processing in the application. Custom forms continue to function normally.

Review Change Stack

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from smarcet May 11, 2026 18:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d2049a59-37a8-48a0-87a7-052c639295be

📥 Commits

Reviewing files that changed from the base of the PR and between 5d1d6f8 and 919d6a0.

📒 Files selected for processing (1)
  • src/reducers/sponsors/sponsor-page-forms-list-reducer.js
💤 Files with no reviewable changes (1)
  • src/reducers/sponsors/sponsor-page-forms-list-reducer.js

📝 Walkthrough

Walkthrough

The PR removes handling of the SPONSOR_MANAGED_FORMS_ADDED action from the sponsor page forms list reducer. The action import is deleted, and the corresponding reducer case statement that processed newly added managed forms is removed. Customized form event handlers remain unchanged.

Changes

Remove Managed Forms Added Action

Layer / File(s) Summary
Action Import Cleanup
src/reducers/sponsors/sponsor-page-forms-list-reducer.js
Import of SPONSOR_MANAGED_FORMS_ADDED action constant is removed from the reducer's imports.
Reducer Case Removal
src/reducers/sponsors/sponsor-page-forms-list-reducer.js
The case SPONSOR_MANAGED_FORMS_ADDED branch is deleted; managed forms no longer receive appended additions and totalCount increments via this action.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • smarcet

Poem

A managed form's action fades away,
Imports are trimmed, the case-branch won't stay,
Custom forms dance on, their flow intact,
Simpler reducer—less code to subtract! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing a reducer case for adding forms using template, which matches the deletion of the SPONSOR_MANAGED_FORMS_ADDED action handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sponsor-form-from-template

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 2a07f4e into master May 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants