Fix | Minimum Speaker Requirement not Enforced#86
Open
matiasperrone-exo wants to merge 2 commits into
Open
Conversation
2cf0e6f to
9001af0
Compare
c470048 to
57bc593
Compare
martinquiroga-exo
previously requested changes
Apr 9, 2026
martinquiroga-exo
left a comment
There was a problem hiding this comment.
@matiasperrone-exo please see comments
Author
|
@martinquiroga-exo please review |
57bc593 to
091d0b1
Compare
091d0b1 to
264de14
Compare
approved by reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b7pq79y
Summary of Changes
Problem
The speaker validation on the presentation speakers form only checked whether at least one speaker existed, ignoring the
min_speakersandmax_speakersconstraints configured on the event type.Changes
src/components/presentation-speakers-form.jsentity.type.min_speakersandentity.type.max_speakers.missing_speakererror message use the tenant-configurable speaker label instead of a hardcoded string.getMarketingValueimport.src/i18n/en.jsonadd_speakererror key with four granular keys:add_speakers,add_only_one_speaker,add_exact_number_of_speakers,add_min_number_speakers.{speaker}parameter.src/i18n/zh.jsonadd_speaker_errorkey.