Skip to content

revert clang tidy suppression - #4877

Open
aouxwoux wants to merge 1 commit into
fmtlib:mainfrom
aouxwoux:agent/revert-clang-tidy-suppression
Open

revert clang tidy suppression#4877
aouxwoux wants to merge 1 commit into
fmtlib:mainfrom
aouxwoux:agent/revert-clang-tidy-suppression

Conversation

@aouxwoux

@aouxwoux aouxwoux commented Aug 2, 2026

Copy link
Copy Markdown

what changed

revert commit 619b3a5, which added the FMT_CLANG_ANALYZER special cases to the compile-string macro and apple file buffer initialization.

why

issue #4871 shows that the suppression removes one clang-tidy false positive but introduces another for FMT_COMPILE and ormatted_size. reverting the suppression restores the original code paths and matches the maintainer's suggested fix.

checks

  • git diff --check passes.
  • the change is an exact reverse of 619b3a5 with no unrelated edits.
  • this checkout does not have cmake or a c++ compiler installed, so i could not run the local test suite.

fixes #4871

@aouxwoux
aouxwoux marked this pull request as ready for review August 2, 2026 16:37
@aouxwoux
aouxwoux requested a review from vitaut as a code owner August 2, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit removing a clang-tidy false positive also introduces one

1 participant