Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
requested review from
cosmicbboy,
davidmirror-ops,
kumare3,
machichima,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
September 19, 2026 18:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to flyteorg/flyte#6473.
Why are the changes needed?
A local workflow cannot check whether an indexed list entry is
None. It raisesAttributeError: 'NoneType' object has no attribute 'union'instead of selecting a branch.What changes were proposed in this pull request?
Resolve indexed operands before evaluating a comparison, using the existing attribute-path resolver. Resolution works on a copy so other uses of the promise keep its original value. Compilation still retains the indexed reference.
How was this patch tested?
The reproducer below fails on current master and succeeds with this change through the same
pyflyte runcommand. This exercises local Flytekit execution without mocks; it does not use a remote Flyte cluster.Testing Done
The base was d69b3fb.
Setup process
Reproducer and raw output
I used Python 3.12.9 and the repository's development requirements in a virtual environment:
Save this as
repro_6473_public.pyin the checkout and put that virtual environment's executables on PATH:I ran these commands in the base and patched checkouts:
Base:
Patched:
Regression cases cover optional boolean entries, right-hand indexed comparisons and serialized reference paths. The existing conditional integration workflow also ran locally with all four combinations of its boolean inputs.
Screenshots
Not applicable.
Check all the applicable boxes
The documented API is unchanged, so this does not need a documentation update.
Related PRs
None.
Docs link
Not applicable.