auth/aws: AWS CodeCommit IAM authentication#1142
auth/aws: AWS CodeCommit IAM authentication#1142taraspos wants to merge 1 commit intofluxcd:mainfrom
Conversation
0a04d24 to
ba8d4f8
Compare
Signed-off-by: Taras Postument <taras.postument@gmail.com>
ba8d4f8 to
c69e541
Compare
| github.com/aws/aws-sdk-go-v2/service/ecrpublic v1.38.9 | ||
| github.com/aws/aws-sdk-go-v2/service/eks v1.77.0 | ||
| github.com/aws/aws-sdk-go-v2/service/sts v1.41.6 | ||
| // TODO: update to the tagged version that includes |
There was a problem hiding this comment.
Agreed, but we can iron out everything else while we're waiting for a new release of aws/smithy-go.
There was a problem hiding this comment.
Sorry, a bit busy at the moment, also this feature can only go in in Flux 2.9, a quarter from now, so we have time
There was a problem hiding this comment.
You can use this time to look into adding integration tests, check tests/integration. You will need an AWS account. You can use it to run the tests locally.
There was a problem hiding this comment.
Got it. Thanks!
Just to better understand the timeline, are we talking about April?
There was a problem hiding this comment.
There was a problem hiding this comment.
Flux 2.8 just got out end of Feb, we're talking at least 3 months after that
There was a problem hiding this comment.
Understood, so it's an end of Q2. Thanks.
Summary
This PR implements IAM role based authentification for AWS CodeCommit Git HTTPS URLs
Testing
Verified locally that generated username and password works AWS CodeCommit repositories.