Skip to content

auth/aws: AWS CodeCommit IAM authentication#1142

Open
taraspos wants to merge 1 commit intofluxcd:mainfrom
taraspos:taras/aws-codecommit
Open

auth/aws: AWS CodeCommit IAM authentication#1142
taraspos wants to merge 1 commit intofluxcd:mainfrom
taraspos:taras/aws-codecommit

Conversation

@taraspos
Copy link

@taraspos taraspos commented Feb 28, 2026

Summary

This PR implements IAM role based authentification for AWS CodeCommit Git HTTPS URLs

Testing

Verified locally that generated username and password works AWS CodeCommit repositories.

@taraspos taraspos changed the title codecommit: initial implementation of git provider auth/aws: AWS CodeCommit IAM authentification Mar 5, 2026
@taraspos taraspos marked this pull request as ready for review March 5, 2026 13:18
@taraspos taraspos requested a review from a team as a code owner March 5, 2026 13:18
@taraspos taraspos force-pushed the taras/aws-codecommit branch 3 times, most recently from 0a04d24 to ba8d4f8 Compare March 5, 2026 13:22
Signed-off-by: Taras Postument <taras.postument@gmail.com>
@taraspos taraspos force-pushed the taras/aws-codecommit branch from ba8d4f8 to c69e541 Compare March 5, 2026 13:23
@makkes makkes changed the title auth/aws: AWS CodeCommit IAM authentification auth/aws: AWS CodeCommit IAM authentication Mar 5, 2026
github.com/aws/aws-sdk-go-v2/service/ecrpublic v1.38.9
github.com/aws/aws-sdk-go-v2/service/eks v1.77.0
github.com/aws/aws-sdk-go-v2/service/sts v1.41.6
// TODO: update to the tagged version that includes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to wait for this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but we can iron out everything else while we're waiting for a new release of aws/smithy-go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a bit busy at the moment, also this feature can only go in in Flux 2.9, a quarter from now, so we have time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use this time to look into adding integration tests, check tests/integration. You will need an AWS account. You can use it to run the tests locally.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks!

Just to better understand the timeline, are we talking about April?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flux 2.8 just got out end of Feb, we're talking at least 3 months after that

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, so it's an end of Q2. Thanks.

@taraspos taraspos requested a review from matheuscscp March 5, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants