fix: reject incomplete Azure KV auth#1670
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Return an error when tenantId and clientId are set without a clientSecret or clientCertificate. This keeps incomplete service principal configs from silently falling back to managed identity, which matches the documented auth modes and makes misconfigurations fail fast. Signed-off-by: immanuwell <pchpr.00@list.ru> Assisted-by: Codex/gpt-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a small Azure Key Vault auth bug.
An incomplete
sops.azure-kvconfig withtenantIdandclientId, but noclientSecretorclientCertificate, was slipping into the managed identity path. That hides a bad secret and picks the wrong auth mode.The fix makes that config fail fast.
clientIdonly still uses managed identity, so existing MI setups keep working.Repro:
TokenCredentialFromAADConfigreturns*azidentity.ManagedIdentityCredentialand no error.Validation:
make tidy fmt vet && make test