feat(firebase): tvOS support for firebase_analytics - #7
Open
TheNoumanDev wants to merge 1 commit into
Open
Conversation
Author
|
@MAUstaoglu @DenisovAV — this adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds federated
firebase_analytics_tvos— Firebase Analytics for Apple TV,built on the Firebase Apple SDK. Re-exports the
firebase_analyticsDart APIand ships the native tvOS
pluginClass; depends onfirebase_core_tvos. Fullanalytics API, no feature disables.
Package(s) touched:
firebase_analytics_tvos(new)How was it tested?
initializeApp(options:)succeeds, Analytics 12.15.0 starts, collectionenabled, and events reach the backend.
Platform.operatingSystem == "tvos"andPlatform.isIOS == trueunder AOT.example/appdart analyzeis clean for the packageVersioning & changelog
version:set to0.0.1(new package)## 0.0.1entry at the top ofCHANGELOG.md0.x: initial0.0.1Checklist
firebase_analytics_tvosfiles are touchedTODO/debug leftREADME.mddocuments tvOS behaviour (no feature limitations; version-alignment note)Notes for reviewers
_tvosleaf packages): the native Pigeon matchesfirebase_analytics 12.4.3andfirebase_core_platform_interface7.1.0 train (firebase_core 4.11.x). Mixingfirebase_core_tvoswith a differentfirebase_corewhoseFirebaseOptionslist differs can crash inCoreFirebaseOptions.fromListat launch (Dartoptions:init).firebase_core_tvos(publish first).