chore(release): 0.0.5 - #19
Merged
Merged
Conversation
Every sibling floor names this batch's release: magic ^0.0.7 -> ^0.0.15, fluttersdk_dusk ^0.0.12 -> ^0.0.15, fluttersdk_telescope ^0.0.5 -> ^0.0.6, fluttersdk_wind ^1.5.0 -> ^1.6.2. Resolving magic 0.0.14+ turned one test red: "emits string-alias middleware names verbatim" routed through an unregistered 'guest' alias, and magic 0.0.14 refuses to build that router. The alias is registered now, and the assertion is exact, so it proves the enricher reports the alias rather than the middleware it resolves to.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave three of an eight-package batch: dusk 0.0.15 and magic 0.0.15 are published, and this re-pins against them.
What ships
Floors only, no code in
lib/moves.magic^0.0.7^0.0.15fluttersdk_dusk^0.0.12^0.0.15fluttersdk_telescope^0.0.5^0.0.6fluttersdk_wind^1.5.0^1.6.2One test was red against magic 0.0.14 and later, unnoticed because master has not run CI since 3 September. "emits string-alias middleware names verbatim" routed through an unregistered
'guest'alias, and magic 0.0.14 refuses to build a router whose route names one (Bad state: Unresolvable route middleware on 1 route). The test's premise, an unregistered alias reaching a snapshot, can no longer happen, so the alias is registered now (and flushed after), and the assertion is exact:magicMiddleware: guest, which proves the enricher reports the alias rather than the middleware it resolves to. Test-only; the enricher is unchanged.Stamps:
pubspec.yamland theREADME.mdinstall snippet.magic:install --with-devtoolsin magic 0.0.15 already writesmagic_devtools: ^0.0.5, so this is the release that request resolves to.The old ranges already admitted the new versions, so a fresh
pub getresolves nothing differently; the floors now name the releases this package is verified against. magic 0.0.15 is breaking in its database layer (a migration may no longer manage its own transaction, andDB.transactionrefuses a callback that closes the transaction itself). Nothing here calls either, so an app below magic 0.0.15 no longer resolves this release but nothing in its behaviour changes.Gates
Run locally against magic 0.0.15 (published since):
flutter analyze --no-fatal-infosno issues,dart format --set-exit-if-changed .0 changed,flutter test110 passed.After this merges
git tag 0.0.5 && git push origin 0.0.5, novprefix.