fix(share_plus): preserve the subject when sharing a URI on iOS - #3997
Draft
kaluli123123 wants to merge 1 commit into
Draft
kaluli123123 wants to merge 1 commit into
kaluli123123 wants to merge 1 commit into
Conversation
Forward the existing share title or legacy subject into the URI share controller. Keep raw NSURL items, completion behavior, and iPad presentation unchanged. Cover subject, title precedence, and no subject through the native registered channel. Closes fluttercommunity#3994 Co-authored-by: Codex <noreply@openai.com>
8 tasks done
Author
|
The repository-wide analyzer failure is also present on the unchanged base commit
This PR remains a draft pending maintainer review; it does not change the unrelated analyzer diagnostics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve the existing share title/legacy subject when sharing a URI on iOS. The URI branch previously passed
nilto the activity controller while the text and file branches forwarded the value. The NSURL share item and existing completion, excluded-activity and popover behavior are unchanged.Added native XCTest coverage through plugin registration and a binary MethodChannel message. The tests inspect a real
UIActivityViewControllerfor the supplied subject, title precedence, and omitted subject. On unchanged production code they report 1 pass and 2 failures; with the fix all 3 pass on an iPhone 17 Pro simulator, iOS 26.5, arm64. The package's Dart tests pass 14 with 1 existing skip, analysis reports no issues, Swift strict formatting and formatting of the modified Objective-C regions pass. Independent read-only review found no blocking issues.The Xcode 27 verification command uses
ARCHS=arm64, deployment target 15 and an isolated test bundle id; these command-line overrides address the unchanged example's baseline build limitations. The published iOS 13 minimum is unchanged. Mail compose UI, physical devices, iPad rendering, iOS 13 runtime and the full cross-platform CI matrix remain unverified. The tests prove controller configuration, not email delivery.Codex assisted implementation, tests and independent review. The GitHub-verified signed delivery tree matches the locally tested tree; this draft remains pending contributor and platform-maintainer review.
Related Issues
Checklist
Breaking Change