Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…tten back Formats the plugin can't write back, such as WebP, were always saved as JPEG, which has no alpha channel, so their transparent pixels were lost. One with an alpha channel is now saved as PNG instead.
agufagit
force-pushed
the
image-picker-ios-keep-alpha
branch
from
October 31, 2026 21:49
3b19730 to
ecfcf94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formats this plugin can't write back, such as WebP, are saved as JPEG, which has no alpha channel, so a transparent image picked on iOS loses its transparency. This saves them as PNG when their metadata reports an alpha channel, using the
kCGImagePropertyHasAlphavalue from the metadata the plugin already reads. Images without an alpha channel are still saved as JPEG, and scaling already keeps the source's opacity.image_picker_androiddoes the same:ImageResizersaves a bitmap with alpha as PNG.The ICO and ICNS test images have alpha channels, so their expected extension changes from
jpgtopng.As with any PNG,
imageQualitydoesn't apply to these images: the existing warning is logged and the image keeps its original quality. GIFs keep their own path, so a transparent GIF stays a GIF.Tested with
RunnerTestson an iOS 26.2 simulator: all 119 pass, and 8 checks fail without the change. A test runs a transparent WebP throughPHPickerSaveImageToPathOperation, but this wasn't tried by hand through the Photos UI.Fixes flutter/flutter#195747
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.🤖 Generated with Claude Code
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2