Skip to content

[material_ui and cupertino_ui] Remove workspaces and fix CI - #12351

Open
justinmc wants to merge 10 commits into
flutter:mainfrom
justinmc:no-workspaces
Open

[material_ui and cupertino_ui] Remove workspaces and fix CI#12351
justinmc wants to merge 10 commits into
flutter:mainfrom
justinmc:no-workspaces

Conversation

@justinmc

@justinmc justinmc commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

It was discovered in the latest cupertino_ui batch release that CI is not set up to handle workspaces yet, causing CI failures. This PR attempts to solve the problem by:

  • Removing workspaces from material_ui_examples and cupertino_ui_examples.
  • Making cupertino_ui depend on material_ui via Pub instead of path.
  • Refactoring away all cross imports in cupertino_ui_examples and removing material_ui as its dependency.

See also flutter/flutter#190453

@justinmc
Remove workspaces from material_ui and cupertino_ui examples.
33f6429 
This was breaking CI as it's not yet supported by the dependency
pathification script.
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 3, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui p: material_ui labels Aug 3, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 3, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the workspace configurations and resolution settings from the pubspec.yaml files of both the cupertino_ui and material_ui packages and their respective examples. No review comments were provided, and there is no additional feedback.

Piinks
Piinks approved these changes Aug 3, 2026
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks

Piinks commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Does this need pending changelogs?

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 3, 2026
@stuartmorgan-g

stuartmorgan-g commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

No, this doesn't affect clients so doesn't need a changelog entry.

@justinmc

justinmc commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Moving this to a draft as I rethink the dependencies. I'm going to try to remove cross imports from cupertino_ui_examples.

@justinmc
justinmc marked this pull request as draft August 3, 2026 18:12
@justinmc
justinmc requested a review from Piinks August 3, 2026 18:46
@justinmc
justinmc marked this pull request as ready for review August 3, 2026 18:46
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 3, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes workspace configurations and replaces Material UI dependencies, imports, widgets, icons, and colors with Cupertino equivalents across the cupertino_ui example and test files. The feedback identifies unused imports of package:cupertino_ui/cupertino_ui.dart in two context menu test files.

Comment thread packages/cupertino_ui/example/test/context_menu/cupertino_context_menu.0_test.dart Outdated
// found in the LICENSE file.

import 'package:material_ui/material_ui.dart';
import 'package:cupertino_ui/cupertino_ui.dart';

@gemini-code-assist gemini-code-assist Bot Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The import of package:cupertino_ui/cupertino_ui.dart is unused in this test file and can be safely removed to avoid linter warnings/errors.

@justinmc justinmc Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used to import FlutterLogo. I've changed it to import widgets instead.

Comment thread packages/cupertino_ui/example/test/context_menu/cupertino_context_menu.1_test.dart Outdated
// found in the LICENSE file.

import 'package:material_ui/material_ui.dart';
import 'package:cupertino_ui/cupertino_ui.dart';

@gemini-code-assist gemini-code-assist Bot Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The import of package:cupertino_ui/cupertino_ui.dart is unused in this test file and can be safely removed to avoid linter warnings/errors.

@justinmc justinmc Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Piinks
Piinks reviewed Aug 3, 2026
View reviewed changes
Comment thread packages/cupertino_ui/example/pubspec.yaml
flutter_lints: ^6.0.0

flutter:
uses-material-design: true

@Piinks Piinks Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Piinks
Piinks reviewed Aug 3, 2026
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the updated cupertino samples, does the API documentation surrounding each sample need to be updated? For example, the list tile one looks fine:

packages/packages/cupertino_ui/lib/src/list_tile.dart

Line 90 in 3498b9d

/// {@example /example/lib/list_tile/cupertino_list_tile.0.dart#body}

@Piinks

Piinks commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Since the cupertino samples changes are user facing, cupertino_ui will need a pending changelog file for this PR now.
Also, CI is a bit sad. :(

@justinmc justinmc changed the title Remove workspaces from material_ui and cupertino_ui examples. [material_ui and cupertino_ui] Remove workspaces and fix CI Aug 3, 2026
@justinmc

justinmc commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

A test started failing after removing material_ui, I'm looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes
@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: cupertino_ui p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinmc @Piinks @stuartmorgan-g