Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
- name: Run dcm checks on packages
# TODO(https://github.com/flutter/devtools/issues/9906): run on all DevTools packages.
run: |
dcm check-unused-code packages/devtools_app packages/devtools_shared --exclude-public-api
dcm check-unused-code packages/devtools_app packages/devtools_app_shared packages/devtools_shared --exclude-public-api

test-packages:
name: ${{ matrix.os }} ${{ matrix.package }} test
Expand Down
7 changes: 3 additions & 4 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,12 @@ dart_code_metrics:
- test/**
exclude:
unused-code:
# TODO(https://github.com/dart-lang/sdk/issues/63864): clean up these
# paths once this issue is fixed. These paths are currently relative to
# devtools_app/.
# TODO(https://github.com/flutter/devtools/issues/9906) remove these
# excludes as findings are resolved.
# This fixture has unused code for testing the debugger.
- test/test_infra/fixtures/flutter_app/**
- packages/devtools_app/test/test_infra/fixtures/flutter_app/**
Comment thread
kenzieschmoll marked this conversation as resolved.
# Ignore unused code in package examples.
- packages/devtools_app_shared/example/**
rules:
# - arguments-ordering Too strict
# - avoid-banned-imports # TODO(polina-c): add configuration
Expand Down
2 changes: 1 addition & 1 deletion flutter-candidate.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0f0246377b1c9d8bc365a439c520a7de6c3f590b
d0da4767346ae787dc60168c8581e3e57ecda6b5
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.

// ignore_for_file: unused-code, this file is exported via config specific exports.

import 'package:web/web.dart';

import '../../utils/url/url.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.

// ignore_for_file: unused-code, this file is exported via config specific exports.

import 'package:web/web.dart';

Map<String, String> loadQueryParams({String Function(String)? urlModifier}) {
Expand Down
Loading