Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors tool/ci/setup.sh to use type -P instead of command -v when resolving the Flutter executable on the PATH, ensuring it resolves to an actual executable rather than a shell function or alias. Additionally, the flutter shell function definition is moved down in the script. A review comment suggests improving the robustness of the flutter function for local Windows development by checking the OSTYPE environment variable in addition to RUNNER_OS.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated setup.sh to:
function flutter { ... }andexport -f flutterbelow theFLUTTER_DIRdetection andPATHexport.command -vtotype -Pwhen resolvingflutter/flutter.batonPATHso it always returns a disk executable path even if afluttershell function or alias is already exported in the parent shell environment.