Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the plugin configuration files (.claude-plugin/plugin.json, .codex-plugin/plugin.json, and .cursor-plugin/plugin.json) to bump their versions to 1.0.5 and inline the mcpServers configuration with specific AGENT_PLUGIN environment variables (claude-code, codex, and cursor respectively), while removing the external .mcp.json file. The feedback suggests adding a trailing newline to the end of each of these JSON files to ensure POSIX compatibility and prevent git diff warnings.
| "mcpServers": { | ||
| "dart-mcp-server": { | ||
| "command": "dart", | ||
| "args": [ | ||
| "mcp-server" | ||
| ], | ||
| "env": { | ||
| "AGENT_PLUGIN": "claude-code" | ||
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
The JSON file is missing a trailing newline at the end of the file. Adding a trailing newline is a standard practice that ensures compatibility with POSIX tools and avoids unnecessary git diff warnings.
| "mcpServers": { | |
| "dart-mcp-server": { | |
| "command": "dart", | |
| "args": [ | |
| "mcp-server" | |
| ], | |
| "env": { | |
| "AGENT_PLUGIN": "claude-code" | |
| } | |
| } | |
| } | |
| } | |
| "mcpServers": { | |
| "dart-mcp-server": { | |
| "command": "dart", | |
| "args": [ | |
| "mcp-server" | |
| ], | |
| "env": { | |
| "AGENT_PLUGIN": "claude-code" | |
| } | |
| } | |
| } | |
| } | |
| } | ||
| } | ||
| } No newline at end of file |
| "skills": "./skills/" | ||
| } | ||
| } No newline at end of file |
This PR
plugin.jsonfile for the respective agents