Repository navigation
feat: show hall filament width sensor - #1981
pedrolamas merged 1 commit into
Conversation
Klipper now reports the runout state for hall_filament_width_sensor, so list it in the runout sensors card along with the measured diameter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Bundle size report (gzip)
119 chunks compared, 24 changed. Sizes are gzip, matching what nginx serves. |
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, well-scoped, and consistent with Klipper's actual hall_filament_width_sensor reporting (verified against its RunoutHelper.get_status and SET_FILAMENT_SENSOR registration), with no regressions for existing sensors or consumers.
0 open findings
What changed in this PR
This PR extends Fluidd's Runout Sensors card to also list Klipper's [hall_filament_width_sensor], which recent Klipper versions now expose with a runout state (enabled, filament_detected) via RunoutHelper. The sensor is rendered alongside existing filament switch/motion sensors, with its enable switch wired to SET_FILAMENT_SENSOR and the live measured filament diameter shown as a subtitle. Sensors that don't report filament_detected (older Klipper) are skipped, keeping existing behavior unchanged.
Changes:
- Added optional
enabled,filament_detected, andflow_compensation_enabledfields toHallFilamentWidthSensorStateand adiameter?field to theRunoutSensortype. - Updated
getRunoutSensorsto includehall_filament_width_sensor, skip sensors withoutfilament_detected, and expose the measured diameter only while width measurement is active. - Rendered the measured diameter as a list-item subtitle in
RunoutSensorsCard.vue.
| File | Description |
|---|---|
src/typings/klipper.d.ts |
Adds optional runout/flow-compensation fields to the hall sensor state type to match Klipper's get_status. |
src/store/printer/types.ts |
Adds optional diameter to RunoutSensor for the measured value. |
src/store/printer/getters.ts |
Includes the hall sensor key, filters out sensors lacking filament_detected, and derives diameter when active. |
src/components/widgets/runout-sensors/RunoutSensorsCard.vue |
Displays the measured diameter as a subtitle when present. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Klipper now reports the runout state (
enabled,filament_detected) for[hall_filament_width_sensor], so it can be listed alongside the filament switch and motion sensors.hall_filament_width_sensorin the Runout Sensors card, with the filament-detected icon and the enable switch (SET_FILAMENT_SENSOR).filament_detectedare skipped, so older Klipper versions that do not report the runout state for this sensor are unaffected.Lint and type-check pass. Not tested against a printer with this sensor.
Signed-off-by: Pedro Lamas pedrolamas@gmail.com
🤖 Generated with Claude Code