test(api/v1alpha1): add runtime and status type coverage by hxrshxz · Pull Request #5891 · fluid-cloudnative/fluid

hxrshxz · 2026-05-17T10:52:06Z

Ⅰ. Describe what this PR does

Add Ginkgo/Gomega coverage for runtime/status API helper types in api/v1alpha1. This PR is intentionally stacked after #5889 locally to reuse the package suite_test.go, but is opened against master for upstream review.

Ⅱ. Does this pull request fix one issue?

#5676

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

add Replicas() coverage for Alluxio, GooseFS, Jindo, JuiceFS, Thin, and Vineyard runtime API types
add GetStatus() and scheme/GVK registration coverage for runtime and CacheRuntime API objects
add lightweight status deepcopy and field-preservation coverage for runtime/cache/operation status structs

Ⅳ. Describe how to verify it

Run the api/v1alpha1 unit tests and confirm the new Ginkgo specs pass.

Ⅴ. Special notes for reviews

Stacked after #5889 conceptually; no dependency on PR2 dataops files, and this diff is test-only.

Signed-off-by: Harsh <harshmastic@gmail.com>

fluid-e2e-bot · 2026-05-17T10:52:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yangyuliufeng for approval by writing /assign @yangyuliufeng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fluid-e2e-bot · 2026-05-17T10:52:24Z

Hi @hxrshxz. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gemini-code-assist

Code Review

This pull request migrates the v1alpha1 API package tests to the Ginkgo and Gomega frameworks, introducing new test files for CacheRuntime, Dataset helpers, and status DeepCopy functionality. It also refactors existing tests for network modes and dataset operations into table-driven Ginkgo specs. Review feedback identifies opportunities to improve code maintainability by using existing constants instead of hardcoded strings and resolving variable shadowing of the runtime package and the built-in copy function.

gemini-code-assist · 2026-05-17T10:54:04Z

+		func(runtime interface{ Replicas() int32 }, expected int32) {
+			Expect(runtime.Replicas()).To(Equal(expected))
+		},


The variable name runtime shadows the imported k8s.io/apimachinery/pkg/runtime package. This can lead to confusion and prevents access to the package's types or functions within this scope. Consider renaming it to something like rt or runtimeObj.

Suggested change

func(runtime interface{ Replicas() int32 }, expected int32) {

Expect(runtime.Replicas()).To(Equal(expected))

},

func(rt interface{ Replicas() int32 }, expected int32) {

Expect(rt.Replicas()).To(Equal(expected))

},

gemini-code-assist · 2026-05-17T10:54:04Z

+		Entry("JindoRuntime", &JindoRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JindoRuntime"}}, &JindoRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JindoRuntimeList"}}, "JindoRuntime", "JindoRuntimeList"),
+		Entry("JuiceFSRuntime", &JuiceFSRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JuiceFSRuntime"}}, &JuiceFSRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JuiceFSRuntimeList"}}, "JuiceFSRuntime", "JuiceFSRuntimeList"),
+		Entry("ThinRuntime", &ThinRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "ThinRuntime"}}, &ThinRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "ThinRuntimeList"}}, "ThinRuntime", "ThinRuntimeList"),
+		Entry("VineyardRuntime", &VineyardRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "VineyardRuntime"}}, &VineyardRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "VineyardRuntimeList"}}, "VineyardRuntime", "VineyardRuntimeList"),


Use the existing constants like JindoRuntimeKind, JuiceFSRuntimeKind, ThinRuntimeKind, and VineyardRuntimeKind instead of hardcoded strings to improve maintainability and avoid potential typos.

Suggested change

Entry("JindoRuntime", &JindoRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JindoRuntime"}}, &JindoRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JindoRuntimeList"}}, "JindoRuntime", "JindoRuntimeList"),

Entry("JuiceFSRuntime", &JuiceFSRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JuiceFSRuntime"}}, &JuiceFSRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JuiceFSRuntimeList"}}, "JuiceFSRuntime", "JuiceFSRuntimeList"),

Entry("ThinRuntime", &ThinRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "ThinRuntime"}}, &ThinRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "ThinRuntimeList"}}, "ThinRuntime", "ThinRuntimeList"),

Entry("VineyardRuntime", &VineyardRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "VineyardRuntime"}}, &VineyardRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "VineyardRuntimeList"}}, "VineyardRuntime", "VineyardRuntimeList"),

Entry("JindoRuntime", &JindoRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: JindoRuntimeKind}}, &JindoRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JindoRuntimeList"}}, JindoRuntimeKind, "JindoRuntimeList"),

Entry("JuiceFSRuntime", &JuiceFSRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: JuiceFSRuntimeKind}}, &JuiceFSRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JuiceFSRuntimeList"}}, JuiceFSRuntimeKind, "JuiceFSRuntimeList"),

Entry("ThinRuntime", &ThinRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: ThinRuntimeKind}}, &ThinRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "ThinRuntimeList"}}, ThinRuntimeKind, "ThinRuntimeList"),

Entry("VineyardRuntime", &VineyardRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: VineyardRuntimeKind}}, &VineyardRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "VineyardRuntimeList"}}, VineyardRuntimeKind, "VineyardRuntimeList"),

gemini-code-assist · 2026-05-17T10:54:04Z

+				CacheAffinity: &corev1.NodeAffinity{},
+			}
+
+			copy := status.DeepCopy()


The variable name copy shadows the built-in copy function. It is recommended to use a different name like cloned or statusCopy to avoid potential confusion with the built-in function.

Copilot

Pull request overview

Test-only PR that adds Ginkgo/Gomega coverage for runtime and status API helper types under api/v1alpha1. It introduces a Ginkgo test suite entry point for the package and per-type specs for runtime Replicas()/GetStatus(), scheme/GVK registration, and deep-copy/field preservation behavior for the runtime, cache runtime, and operation status structs. Stacked conceptually on #5889, so several of the diffed test files (suite, common, container_network, dataset) overlap with that PR.

Changes:

Add Replicas() table tests for Alluxio/GooseFS/Jindo/JuiceFS/Thin/Vineyard runtimes and GetStatus() specs for each, plus scheme-registration table for runtime/list GVKs.
Add CacheRuntime.GetStatus() and scheme-registration coverage.
Add deep-copy/field-preservation specs for RuntimeStatus, CacheRuntimeStatus, and OperationStatus.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
api/v1alpha1/suite_test.go	New Ginkgo `TestV1alpha1` entry point for the package suite.
api/v1alpha1/common_test.go	New specs for `MetadataSyncPolicy.AutoSyncEnabled`, `Dataset.CanbeBound`, `Dataset.IsExclusiveMode` (note: license header is tab-indented).
api/v1alpha1/container_network_test.go	Migrates `IsHostNetwork` test to Ginkgo `DescribeTable`.
api/v1alpha1/dataset_types_test.go	Migrates Dataset operation-ref tests to Ginkgo `DescribeTable`.
api/v1alpha1/runtime_types_test.go	Adds runtime `Replicas`/`GetStatus`/scheme-registration tests for six runtimes (EFC omitted).
api/v1alpha1/cacheruntime_types_test.go	Adds `CacheRuntime.GetStatus` and scheme registration test.
api/v1alpha1/status_test.go	Adds DeepCopy specs for `RuntimeStatus`, `CacheRuntimeStatus`, `OperationStatus` (uses `copy` identifier that shadows the builtin).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+		Entry("AlluxioRuntime", &AlluxioRuntime{Spec: AlluxioRuntimeSpec{Replicas: 1}}, int32(1)),
+		Entry("GooseFSRuntime", &GooseFSRuntime{Spec: GooseFSRuntimeSpec{Replicas: 2}}, int32(2)),
+		Entry("JindoRuntime", &JindoRuntime{Spec: JindoRuntimeSpec{Replicas: 3}}, int32(3)),
+		Entry("JuiceFSRuntime", &JuiceFSRuntime{Spec: JuiceFSRuntimeSpec{Replicas: 4}}, int32(4)),
+		Entry("ThinRuntime", &ThinRuntime{Spec: ThinRuntimeSpec{Replicas: 5}}, int32(5)),
+		Entry("VineyardRuntime", &VineyardRuntime{Spec: VineyardRuntimeSpec{Replicas: 6}}, int32(6)),


+	you may not use this file except in compliance with the License.
+	You may obtain a copy of the License at
+
+	    http://www.apache.org/licenses/LICENSE-2.0
+
+	Unless required by applicable law or agreed to in writing, software
+	distributed under the License is distributed on an "AS IS" BASIS,
+	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+	See the License for the specific language governing permissions and
+	limitations under the License.
+*/


+			copy := status.DeepCopy()
+
+			Expect(copy).NotTo(BeNil())
+			Expect(copy).NotTo(BeIdenticalTo(status))
+			Expect(copy.WorkerPhase).To(Equal(RuntimePhaseReady))
+			Expect(copy.Conditions).To(HaveLen(1))
+			Expect(copy.Conditions[0].Reason).To(Equal(RuntimeWorkersReadyReason))
+			Expect(copy.MountTime).NotTo(BeNil())
+			Expect(copy.MountTime).NotTo(BeIdenticalTo(status.MountTime))
+			Expect(copy.MountTime.Time).To(Equal(status.MountTime.Time))
+			Expect(copy.Mounts).To(HaveLen(1))
+			Expect(copy.Mounts[0].MountPoint).To(Equal("s3://bucket/data"))
+
+			copy.Mounts[0].MountPoint = "changed"


codecov · 2026-05-17T10:58:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.65%. Comparing base (ed9b7ef) to head (f75e60b).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5891   +/-   ##
=======================================
  Coverage   61.65%   61.65%           
=======================================
  Files         480      480           
  Lines       32613    32613           
=======================================
  Hits        20108    20108           
  Misses      10897    10897           
  Partials     1608     1608

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Harsh <harshmastic@gmail.com>

hxrshxz · 2026-05-17T11:52:38Z

/gemini review

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

@@ -0,0 +1,47 @@
+/*
+Copyright 2020 The Fluid Authors.


gemini-code-assist

Code Review

This pull request refactors the v1alpha1 API unit tests to use the Ginkgo and Gomega frameworks, adding coverage for CacheRuntime, Dataset operations, network modes, and status deep-copy helpers. The reviewer suggested improving the EFCRuntime.Replicas test by adding a case for disabled workers and recommended using Kind constants instead of hardcoded strings in test tables for better consistency.

gemini-code-assist · 2026-05-17T11:54:09Z

+		Entry(EFCRuntimeKind, &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2}}, int32(2)),
+		Entry("GooseFSRuntime", &GooseFSRuntime{Spec: GooseFSRuntimeSpec{Replicas: 2}}, int32(2)),
+		Entry("JindoRuntime", &JindoRuntime{Spec: JindoRuntimeSpec{Replicas: 3}}, int32(3)),
+		Entry("JuiceFSRuntime", &JuiceFSRuntime{Spec: JuiceFSRuntimeSpec{Replicas: 4}}, int32(4)),
+		Entry("ThinRuntime", &ThinRuntime{Spec: ThinRuntimeSpec{Replicas: 5}}, int32(5)),
+		Entry("VineyardRuntime", &VineyardRuntime{Spec: VineyardRuntimeSpec{Replicas: 6}}, int32(6)),


The EFCRuntime.Replicas() implementation includes specific logic to return 0 if the worker is disabled; this edge case should be covered in the test table. Additionally, use the available Kind constants (e.g., JindoRuntimeKind, JuiceFSRuntimeKind, etc.) for entry names to improve consistency and avoid hardcoded strings.

Entry(EFCRuntimeKind, &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2}}, int32(2)), Entry(EFCRuntimeKind+" (disabled)", &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2, Worker: EFCCompTemplateSpec{Disabled: true}}}, int32(0)), Entry("GooseFSRuntime", &GooseFSRuntime{Spec: GooseFSRuntimeSpec{Replicas: 2}}, int32(2)), Entry(JindoRuntimeKind, &JindoRuntime{Spec: JindoRuntimeSpec{Replicas: 3}}, int32(3)), Entry(JuiceFSRuntimeKind, &JuiceFSRuntime{Spec: JuiceFSRuntimeSpec{Replicas: 4}}, int32(4)), Entry(ThinRuntimeKind, &ThinRuntime{Spec: ThinRuntimeSpec{Replicas: 5}}, int32(5)), Entry(VineyardRuntimeKind, &VineyardRuntime{Spec: VineyardRuntimeSpec{Replicas: 6}}, int32(6)),

gemini-code-assist · 2026-05-17T11:54:09Z

+		Entry("EFCRuntime", &EFCRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: EFCRuntimeKind}}, &EFCRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "EFCRuntimeList"}}, EFCRuntimeKind, "EFCRuntimeList"),
+		Entry("GooseFSRuntime", &GooseFSRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "GooseFSRuntime"}}, &GooseFSRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "GooseFSRuntimeList"}}, "GooseFSRuntime", "GooseFSRuntimeList"),
+		Entry("JindoRuntime", &JindoRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: JindoRuntimeKind}}, &JindoRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JindoRuntimeList"}}, JindoRuntimeKind, "JindoRuntimeList"),
+		Entry("JuiceFSRuntime", &JuiceFSRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: JuiceFSRuntimeKind}}, &JuiceFSRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JuiceFSRuntimeList"}}, JuiceFSRuntimeKind, "JuiceFSRuntimeList"),
+		Entry("ThinRuntime", &ThinRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: ThinRuntimeKind}}, &ThinRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "ThinRuntimeList"}}, ThinRuntimeKind, "ThinRuntimeList"),
+		Entry("VineyardRuntime", &VineyardRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: VineyardRuntimeKind}}, &VineyardRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "VineyardRuntimeList"}}, VineyardRuntimeKind, "VineyardRuntimeList"),


Use the available Kind constants for the entry names to maintain consistency with the Replicas table and avoid hardcoded strings where possible.

Suggested change

Entry("EFCRuntime", &EFCRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: EFCRuntimeKind}}, &EFCRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "EFCRuntimeList"}}, EFCRuntimeKind, "EFCRuntimeList"),

Entry("GooseFSRuntime", &GooseFSRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "GooseFSRuntime"}}, &GooseFSRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "GooseFSRuntimeList"}}, "GooseFSRuntime", "GooseFSRuntimeList"),

Entry("JindoRuntime", &JindoRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: JindoRuntimeKind}}, &JindoRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JindoRuntimeList"}}, JindoRuntimeKind, "JindoRuntimeList"),

Entry("JuiceFSRuntime", &JuiceFSRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: JuiceFSRuntimeKind}}, &JuiceFSRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JuiceFSRuntimeList"}}, JuiceFSRuntimeKind, "JuiceFSRuntimeList"),

Entry("ThinRuntime", &ThinRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: ThinRuntimeKind}}, &ThinRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "ThinRuntimeList"}}, ThinRuntimeKind, "ThinRuntimeList"),

Entry("VineyardRuntime", &VineyardRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: VineyardRuntimeKind}}, &VineyardRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "VineyardRuntimeList"}}, VineyardRuntimeKind, "VineyardRuntimeList"),

Entry(EFCRuntimeKind, &EFCRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: EFCRuntimeKind}}, &EFCRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "EFCRuntimeList"}}, EFCRuntimeKind, "EFCRuntimeList"),

Entry("GooseFSRuntime", &GooseFSRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "GooseFSRuntime"}}, &GooseFSRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "GooseFSRuntimeList"}}, "GooseFSRuntime", "GooseFSRuntimeList"),

Entry(JindoRuntimeKind, &JindoRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: JindoRuntimeKind}}, &JindoRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JindoRuntimeList"}}, JindoRuntimeKind, "JindoRuntimeList"),

Entry(JuiceFSRuntimeKind, &JuiceFSRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: JuiceFSRuntimeKind}}, &JuiceFSRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JuiceFSRuntimeList"}}, JuiceFSRuntimeKind, "JuiceFSRuntimeList"),

Entry(ThinRuntimeKind, &ThinRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: ThinRuntimeKind}}, &ThinRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "ThinRuntimeList"}}, ThinRuntimeKind, "ThinRuntimeList"),

Entry(VineyardRuntimeKind, &VineyardRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: VineyardRuntimeKind}}, &VineyardRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "VineyardRuntimeList"}}, VineyardRuntimeKind, "VineyardRuntimeList"),

Signed-off-by: Harsh <harshmastic@gmail.com>

hxrshxz · 2026-05-17T11:57:16Z

/gemini review

gemini-code-assist

Code Review

This pull request migrates and expands the unit tests for the v1alpha1 API package to use the Ginkgo and Gomega frameworks. It introduces new test files for CacheRuntime, MetadataSyncPolicy, and various Runtime types, while refactoring existing tests for IsHostNetwork and Dataset methods into table-driven Ginkgo tests. Additionally, it adds comprehensive DeepCopy verification for status objects. The reviewer suggests strengthening the DeepCopy tests by ensuring nested pointer identities and values are correctly verified, and increasing test coverage for the EFCRuntime.Replicas logic.

gemini-code-assist · 2026-05-17T11:59:22Z

+			Expect(copied.Mounts).To(HaveLen(1))
+			Expect(copied.Mounts[0].MountPoint).To(Equal("s3://bucket/data"))


The DeepCopy test for RuntimeStatus initializes CacheAffinity but does not verify that it is correctly deep-copied. Adding a pointer identity check ensures that the nested object is a new instance and not a shallow copy.

Suggested change

Expect(copied.Mounts).To(HaveLen(1))

Expect(copied.Mounts[0].MountPoint).To(Equal("s3://bucket/data"))

Expect(copied.Mounts).To(HaveLen(1))

Expect(copied.Mounts[0].MountPoint).To(Equal("s3://bucket/data"))

Expect(copied.CacheAffinity).NotTo(BeNil())

Expect(copied.CacheAffinity).NotTo(BeIdenticalTo(status.CacheAffinity))

gemini-code-assist · 2026-05-17T11:59:23Z

+			Expect(copied.Worker.Phase).To(Equal(RuntimePhasePartialReady))
+			Expect(copied.MountPoints).To(HaveLen(1))
+			Expect(copied.MountPoints[0].Mount.MountPoint).To(Equal("/data/cache"))
+			Expect(copied.MountPoints[0].MountTime).NotTo(BeIdenticalTo(status.MountPoints[0].MountTime))


It is recommended to verify the value of MountTime in addition to its pointer identity to ensure data integrity after the deep copy.

Suggested change

Expect(copied.MountPoints[0].MountTime).NotTo(BeIdenticalTo(status.MountPoints[0].MountTime))

Expect(copied.MountPoints[0].MountTime).NotTo(BeIdenticalTo(status.MountPoints[0].MountTime))

Expect(copied.MountPoints[0].MountTime.Time).To(Equal(status.MountPoints[0].MountTime.Time))

gemini-code-assist · 2026-05-17T11:59:23Z

+			Expect(copied.WaitingFor.OperationComplete).NotTo(BeNil())
+			Expect(*copied.WaitingFor.OperationComplete).To(BeTrue())


The DeepCopy test for OperationStatus should verify that nested pointers like WaitingFor.OperationComplete and NodeAffinity are actually deep-copied by checking their pointer identity.

Suggested change

Expect(copied.WaitingFor.OperationComplete).NotTo(BeNil())

Expect(*copied.WaitingFor.OperationComplete).To(BeTrue())

Expect(copied.WaitingFor.OperationComplete).NotTo(BeNil())

Expect(*copied.WaitingFor.OperationComplete).To(BeTrue())

Expect(copied.WaitingFor.OperationComplete).NotTo(BeIdenticalTo(status.WaitingFor.OperationComplete))

Expect(copied.NodeAffinity).NotTo(BeNil())

Expect(copied.NodeAffinity).NotTo(BeIdenticalTo(status.NodeAffinity))

gemini-code-assist · 2026-05-17T11:59:23Z

+			Expect(runtimeObj.Replicas()).To(Equal(expected))
+		},
+		Entry("AlluxioRuntime", &AlluxioRuntime{Spec: AlluxioRuntimeSpec{Replicas: 1}}, int32(1)),
+		Entry("EFCRuntime", &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2}}, int32(2)),


The Replicas() method for EFCRuntime contains logic that returns 0 if the runtime is disabled. It would be beneficial to add a test case for this branch to ensure full coverage of the helper method.

Suggested change

Entry("EFCRuntime", &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2}}, int32(2)),

Entry("EFCRuntime", &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2}}, int32(2)),

Entry("EFCRuntime (disabled)", &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2, Worker: EFCCompTemplateSpec{Disabled: true}}}, int32(0)),

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

hxrshxz · 2026-05-17T12:03:19Z

/gemini review

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Signed-off-by: Harsh <harshmastic@gmail.com>

gemini-code-assist

Code Review

This pull request migrates and expands the unit tests for the v1alpha1 API package to use the Ginkgo and Gomega testing frameworks. It introduces new test coverage for CacheRuntime, MetadataSyncPolicy, and various Runtime helpers, while refactoring existing tests for Dataset operations and network modes into table-driven Ginkgo tests. Additionally, it adds comprehensive DeepCopy tests for status objects. The reviewer feedback highlights opportunities to improve maintainability by consistently using defined Kind constants instead of hardcoded string literals in the test tables for runtime objects and scheme registration.

gemini-code-assist · 2026-05-17T12:08:26Z

+		Entry("AlluxioRuntime", &AlluxioRuntime{Spec: AlluxioRuntimeSpec{Replicas: 1}}, int32(1)),
+		Entry("EFCRuntime", &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2}}, int32(2)),
+		Entry("EFCRuntime disabled worker", &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2, Worker: EFCCompTemplateSpec{Disabled: true}}}, int32(0)),
+		Entry("GooseFSRuntime", &GooseFSRuntime{Spec: GooseFSRuntimeSpec{Replicas: 2}}, int32(2)),
+		Entry(JindoRuntimeKind, &JindoRuntime{Spec: JindoRuntimeSpec{Replicas: 3}}, int32(3)),
+		Entry(JuiceFSRuntimeKind, &JuiceFSRuntime{Spec: JuiceFSRuntimeSpec{Replicas: 4}}, int32(4)),
+		Entry(ThinRuntimeKind, &ThinRuntime{Spec: ThinRuntimeSpec{Replicas: 5}}, int32(5)),
+		Entry(VineyardRuntimeKind, &VineyardRuntime{Spec: VineyardRuntimeSpec{Replicas: 6}}, int32(6)),


The entry names in this table are inconsistent. Some use string literals (e.g., "AlluxioRuntime", "EFCRuntime") while others use Kind constants (e.g., JindoRuntimeKind, JuiceFSRuntimeKind). For better maintainability and to avoid potential typos, it is recommended to use the defined Kind constants consistently for all entry names where they are available.

gemini-code-assist · 2026-05-17T12:08:27Z

+		Entry("AlluxioRuntime", &AlluxioRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "AlluxioRuntime"}}, &AlluxioRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "AlluxioRuntimeList"}}, "AlluxioRuntime", "AlluxioRuntimeList"),
+		Entry("EFCRuntime", &EFCRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: EFCRuntimeKind}}, &EFCRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "EFCRuntimeList"}}, EFCRuntimeKind, "EFCRuntimeList"),
+		Entry("GooseFSRuntime", &GooseFSRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "GooseFSRuntime"}}, &GooseFSRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "GooseFSRuntimeList"}}, "GooseFSRuntime", "GooseFSRuntimeList"),
+		Entry(JindoRuntimeKind, &JindoRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: JindoRuntimeKind}}, &JindoRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JindoRuntimeList"}}, JindoRuntimeKind, "JindoRuntimeList"),
+		Entry(JuiceFSRuntimeKind, &JuiceFSRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: JuiceFSRuntimeKind}}, &JuiceFSRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "JuiceFSRuntimeList"}}, JuiceFSRuntimeKind, "JuiceFSRuntimeList"),
+		Entry(ThinRuntimeKind, &ThinRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: ThinRuntimeKind}}, &ThinRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "ThinRuntimeList"}}, ThinRuntimeKind, "ThinRuntimeList"),
+		Entry(VineyardRuntimeKind, &VineyardRuntime{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: VineyardRuntimeKind}}, &VineyardRuntimeList{TypeMeta: metav1.TypeMeta{APIVersion: GroupVersion.String(), Kind: "VineyardRuntimeList"}}, VineyardRuntimeKind, "VineyardRuntimeList"),


There is an inconsistency in how runtime Kind names are referenced in this registration table. Some entries hardcode the Kind as a string literal (e.g., "AlluxioRuntime", "GooseFSRuntime"), while others correctly use the defined constants (e.g., EFCRuntimeKind, JindoRuntimeKind). Please use the defined Kind constants consistently across all entries to improve maintainability and ensure alignment with the API definitions.

sonarqubecloud · 2026-05-17T12:09:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cheyang · 2026-05-18T02:36:43Z

/ok-to-test

test(api/v1alpha1): migrate core API tests to ginkgo

61f28ff

Signed-off-by: Harsh <harshmastic@gmail.com>

Copilot AI review requested due to automatic review settings May 17, 2026 10:52

fluid-e2e-bot Bot added the needs-ok-to-test label May 17, 2026

Copilot started reviewing on behalf of hxrshxz May 17, 2026 10:52 View session

gemini-code-assist Bot reviewed May 17, 2026

View reviewed changes

Copilot AI reviewed May 17, 2026

View reviewed changes

test(api/v1alpha1): address round-1 review feedback

318ec61

Signed-off-by: Harsh <harshmastic@gmail.com>

hxrshxz force-pushed the test/api-v1alpha1-runtimes-ginkgo branch from 03b643a to a334163 Compare May 17, 2026 11:06

hxrshxz requested a review from Copilot May 17, 2026 11:52

Copilot started reviewing on behalf of hxrshxz May 17, 2026 11:52 View session

Copilot AI reviewed May 17, 2026

View reviewed changes

Comment thread api/v1alpha1/common_test.go Outdated

@@ -0,0 +1,47 @@

/*

Copyright 2020 The Fluid Authors.

gemini-code-assist Bot reviewed May 17, 2026

View reviewed changes

test(api/v1alpha1): refine dataset helper specs

3fbd736

Signed-off-by: Harsh <harshmastic@gmail.com>

hxrshxz force-pushed the test/api-v1alpha1-runtimes-ginkgo branch from 3673d81 to 4c2ad5f Compare May 17, 2026 11:55

gemini-code-assist Bot reviewed May 17, 2026

View reviewed changes

hxrshxz requested a review from Copilot May 17, 2026 11:59

Copilot started reviewing on behalf of hxrshxz May 17, 2026 11:59 View session

Copilot AI reviewed May 17, 2026

View reviewed changes

hxrshxz requested a review from Copilot May 17, 2026 12:05

Copilot started reviewing on behalf of hxrshxz May 17, 2026 12:06 View session

Copilot AI reviewed May 17, 2026

View reviewed changes

hxrshxz added 3 commits May 17, 2026 17:37

test(api/v1alpha1): tighten dataset operation tables

515154a

Signed-off-by: Harsh <harshmastic@gmail.com>

test(api/v1alpha1): add runtime and status type coverage

45b7fed

Signed-off-by: Harsh <harshmastic@gmail.com>

test(api/v1alpha1): cover efc runtime helpers

114c6c8

Signed-off-by: Harsh <harshmastic@gmail.com>

hxrshxz added 4 commits May 17, 2026 17:38

test(api/v1alpha1): clarify efc runtime coverage

db25ac2

Signed-off-by: Harsh <harshmastic@gmail.com>

test(api/v1alpha1): annotate efc helper parity

ae5a29c

Signed-off-by: Harsh <harshmastic@gmail.com>

test(api/v1alpha1): make efc helper entry explicit

523b0d7

Signed-off-by: Harsh <harshmastic@gmail.com>

test(api/v1alpha1): tighten runtime helper assertions

f75e60b

Signed-off-by: Harsh <harshmastic@gmail.com>

gemini-code-assist Bot reviewed May 17, 2026

View reviewed changes

hxrshxz force-pushed the test/api-v1alpha1-runtimes-ginkgo branch from 3816c87 to f75e60b Compare May 17, 2026 12:08

fluid-e2e-bot Bot added ok-to-test and removed needs-ok-to-test labels May 18, 2026

		Expect(copied.Mounts).To(HaveLen(1))
		Expect(copied.Mounts[0].MountPoint).To(Equal("s3://bucket/data"))

	Expect(copied.MountPoints[0].MountTime).NotTo(BeIdenticalTo(status.MountPoints[0].MountTime))
	Expect(copied.MountPoints[0].MountTime).NotTo(BeIdenticalTo(status.MountPoints[0].MountTime))
	Expect(copied.MountPoints[0].MountTime.Time).To(Equal(status.MountPoints[0].MountTime.Time))

		Expect(copied.WaitingFor.OperationComplete).NotTo(BeNil())
		Expect(*copied.WaitingFor.OperationComplete).To(BeTrue())

	Entry("EFCRuntime", &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2}}, int32(2)),
	Entry("EFCRuntime", &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2}}, int32(2)),
	Entry("EFCRuntime (disabled)", &EFCRuntime{Spec: EFCRuntimeSpec{Replicas: 2, Worker: EFCCompTemplateSpec{Disabled: true}}}, int32(0)),

Conversation

hxrshxz commented May 17, 2026

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

fluid-e2e-bot Bot commented May 17, 2026

Uh oh!

fluid-e2e-bot Bot commented May 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codecov Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hxrshxz commented May 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

hxrshxz commented May 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

hxrshxz commented May 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

codecov Bot commented May 17, 2026 •

edited

Loading