Extend CacheRuntime phase 2.5: transform Cache Runtime Spec into pods spec#5888
Extend CacheRuntime phase 2.5: transform Cache Runtime Spec into pods spec#5888xliuqq wants to merge 4 commits into
Conversation
Signed-off-by: xliuqq <xlzq1992@gmail.com> fix affinity
Signed-off-by: xliuqq <xlzq1992@gmail.com>
Signed-off-by: xliuqq <xlzq1992@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request refactors the CacheEngine component transformation and status update logic to be more modular and efficient. It introduces lightweight status tracking using ComponentIdentity and consolidates volume and pod template transformations into shared helper functions. Additionally, it replaces hardcoded labels with constants and significantly expands test coverage. Feedback identifies a bug in worker affinity construction where existing node affinity preferences are overwritten, and a potential issue with duplicate volume names in pod specs due to incomplete tracking of previously added volumes.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5888 +/- ##
==========================================
+ Coverage 61.65% 63.20% +1.55%
==========================================
Files 480 481 +1
Lines 32613 32873 +260
==========================================
+ Hits 20108 20779 +671
+ Misses 10897 10435 -462
- Partials 1608 1659 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: xliuqq <xlzq1992@gmail.com>
|



Ⅰ. Describe what this PR does
transform Cache Runtime Spec into master/worker/client pods spec
Ⅱ. Does this pull request fix one issue?
part of #5412 and fix #5877
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
unit test
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
RuntimeTieredStorefor worker/client and storage for master(ha) not yet resolved