Backport(v1.19): test_buffer: make gzip chunk overflow test independent of zlib implementation (#5415)#5426
Open
github-actions[bot] wants to merge 1 commit into
Open
Backport(v1.19): test_buffer: make gzip chunk overflow test independent of zlib implementation (#5415)#5426github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…entation (#5415) **Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: The gzipped size of a record varies by a few bytes depending on the zlib implementation. zlib-ng, which is used by default on some distributions, produces slightly larger output for tiny records than stock zlib. The test hard-coded chunk_limit_size to 70 and implicitly assumed the small "aaa"/"bbb" records stay under that limit, which holds for stock zlib but not for zlib-ng where they compress to 72 bytes. As a result, those records also triggered BufferChunkOverflowError locally and the test failed, while it kept passing on CI (stock zlib). Derive chunk_limit_size from the actual gzipped size of the small records so they always fit into (and fill up) a chunk, and enlarge the overflowing record so it exceeds the limit by a wide margin regardless of the zlib implementation. **Docs Changes**: N/A **Release Note**: N/A Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Backport #5415
Fixes #
What this PR does / why we need it:
The gzipped size of a record varies by a few bytes depending on the zlib implementation. zlib-ng, which is used by default on some distributions, produces slightly larger output for tiny records than stock zlib.
The test hard-coded chunk_limit_size to 70 and implicitly assumed the small "aaa"/"bbb" records stay under that limit, which holds for stock zlib but not for zlib-ng where they compress to 72 bytes. As a result, those records also triggered BufferChunkOverflowError locally and the test failed, while it kept passing on CI (stock zlib).
Derive chunk_limit_size from the actual gzipped size of the small records so they always fit into (and fill up) a chunk, and enlarge the overflowing record so it exceeds the limit by a wide margin regardless of the zlib implementation.
Docs Changes:
N/A
Release Note:
N/A