Skip to content

pipeline: processors: sampling: fixed indentation of sample configs#2415

Merged
lecaros merged 1 commit intomasterfrom
lecaros-fix-sampling-configs
Mar 11, 2026
Merged

pipeline: processors: sampling: fixed indentation of sample configs#2415
lecaros merged 1 commit intomasterfrom
lecaros-fix-sampling-configs

Conversation

@lecaros
Copy link
Contributor

@lecaros lecaros commented Mar 11, 2026

conditions is expected at the same level that sampling_settings

Summary by CodeRabbit

  • Documentation
    • Improved formatting and indentation consistency in sampling configuration documentation for enhanced readability and clearer presentation of configuration examples.

Signed-off-by: lecaros <lecaros@chronosphere.io>
@lecaros lecaros requested review from a team and eschabell as code owners March 11, 2026 20:16
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3cff3434-11b8-4385-bbcf-0b9f6e9a5ae7

📥 Commits

Reviewing files that changed from the base of the PR and between 1481ad4 and a9f46bc.

📒 Files selected for processing (1)
  • pipeline/processors/sampling.md

📝 Walkthrough

Walkthrough

Reorganized YAML indentation and spacing in the sampling documentation file to improve alignment and readability of tail sampling configurations. The restructuring adjusts condition blocks and line breaks without modifying actual key/value content, parameter values, or logic.

Changes

Cohort / File(s) Summary
YAML Formatting
pipeline/processors/sampling.md
Realigned YAML indentation and spacing across multiple tail sampling configuration blocks for consistency and readability. Comment placement and line breaks adjusted to maintain uniform structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Indentation dances in perfect alignment,
Spaces and tabs now sing in sweet alignment,
The YAML straightens with rabbit-like care,
Each line finds its place with precision so rare!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: fixing indentation in sampling configuration files within the pipeline processors documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch lecaros-fix-sampling-configs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lecaros lecaros merged commit 8015e27 into master Mar 11, 2026
8 checks passed
@lecaros lecaros deleted the lecaros-fix-sampling-configs branch March 11, 2026 20:21
@eschabell
Copy link
Collaborator

bit late to review if you already merged it @lecaros :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants