Skip to content

docs: outputs: azure_blob: fix defaults, add missing params, fix key casing, fix typo#2414

Merged
eschabell merged 2 commits intofluent:masterfrom
eschabell:erics-out-azure-blob-updates
Mar 12, 2026
Merged

docs: outputs: azure_blob: fix defaults, add missing params, fix key casing, fix typo#2414
eschabell merged 2 commits intofluent:masterfrom
eschabell:erics-out-azure-blob-updates

Conversation

@eschabell
Copy link
Collaborator

@eschabell eschabell commented Mar 11, 2026

  • Fix typo: azure_blog → azure_blob in both YAML config examples
  • Fix auto_create_container default: on → true (source-verified)
  • Fix compress_blob default: none → false (source-verified)
  • Fix emulator_mode default: off → false (source-verified)
  • Add missing period to compress description
  • Add 11 undocumented parameters
  • Sort parameter table alphabetically
  • Fix classic config key casing to Title_Case in both [SERVICE], [INPUT], and [OUTPUT] blocks across both config examples

Applies to #2412

Summary by CodeRabbit

  • Documentation
    • Restructured Azure Blob output configuration and clarified parameter names and styles.
    • Updated default values and introduced additional configuration options for buffering, retries, part uploads, and emulator support.
    • Corrected and standardized sample configurations and examples across formats to reflect the new parameter set.

…casing, fix typo

  - Fix typo: azure_blog → azure_blob in both YAML config examples
  - Fix auto_create_container default: on → true (source-verified)
  - Fix compress_blob default: _none_ → false (source-verified)
  - Fix emulator_mode default: off → false (source-verified)
  - Add missing period to compress description
  - Add 11 undocumented parameters
  - Sort parameter table alphabetically
  - Fix classic config key casing to Title_Case in both [SERVICE], [INPUT], and [OUTPUT] blocks across both config examples

Applies to fluent#2412

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-assigned this Mar 11, 2026
@eschabell eschabell requested a review from a team as a code owner March 11, 2026 15:07
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.0 labels Mar 11, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3b6a11f9-466e-4c15-93ec-7106571c18e1

📥 Commits

Reviewing files that changed from the base of the PR and between b74315b and d181cf0.

📒 Files selected for processing (1)
  • pipeline/outputs/azure_blob.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • pipeline/outputs/azure_blob.md

📝 Walkthrough

Walkthrough

Rewrote the Azure Blob output documentation: configuration table reorganized, many keys renamed or added (including emulator-related fields), defaults adjusted (e.g., auto_create_container), and examples updated to use consistent naming and corrected references to azure_blob.

Changes

Cohort / File(s) Summary
Azure Blob Configuration Documentation
pipeline/outputs/azure_blob.md
Completely restructured configuration table and examples: renamed keys, added new parameters (e.g., azure_blob_buffer_key, file_delivery_attempt_limit, part_delivery_attempt_limit, part_size, upload_part_freshness_limit, upload_parts_timeout, database_file, date_key, configuration_endpoint_*), introduced emulator_mode/endpoint and TLS-related fields, changed defaults (e.g., auto_create_container from on to true), and standardized casing/formatting across examples (corrected azure_blogazure_blob).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • cosmo0920
  • patrick-stephens

Poem

🐰 In configs snug beneath a log,

I hop and patch each tiny cog.
From "blog" to "blob" I nudge the name,
New options bloom and defaults tame.
A tidy doc—my rabbit fame! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: fixes defaults, adds missing parameters, fixes key casing, and corrects a typo in the Azure Blob documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pipeline/outputs/azure_blob.md`:
- Line 26: The description for the `blob_uri_length` setting incorrectly
references "ingesting to Azure Kusto"—update the text to describe Azure Blob
behavior instead: state that `blob_uri_length` controls the length of the
generated blob URI (or blob name/object key) used when creating/uploading
objects to Azure Blob Storage, and that the default is `64`; modify the
`blob_uri_length` entry in the table to replace the Kusto reference with this
accurate Azure Blob description.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 02e3c8f7-dcb8-492c-8c41-af346c09291c

📥 Commits

Reviewing files that changed from the base of the PR and between 1481ad4 and b74315b.

📒 Files selected for processing (1)
  • pipeline/outputs/azure_blob.md

  - Fix blob_uri_length description
  - Fix table column alignment on azure_blob_buffer_key and blob_uri_length rows (off by one space)

Applies to fluent#2412

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell
Copy link
Collaborator Author

@cosmo0920 and @patrick-stephens ready for review!

@eschabell eschabell merged commit 0cd08f3 into fluent:master Mar 12, 2026
8 checks passed
@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Mar 12, 2026
@eschabell eschabell deleted the erics-out-azure-blob-updates branch March 12, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants