docs: outputs: azure_blob: fix defaults, add missing params, fix key casing, fix typo#2414
Conversation
…casing, fix typo - Fix typo: azure_blog → azure_blob in both YAML config examples - Fix auto_create_container default: on → true (source-verified) - Fix compress_blob default: _none_ → false (source-verified) - Fix emulator_mode default: off → false (source-verified) - Add missing period to compress description - Add 11 undocumented parameters - Sort parameter table alphabetically - Fix classic config key casing to Title_Case in both [SERVICE], [INPUT], and [OUTPUT] blocks across both config examples Applies to fluent#2412 Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRewrote the Azure Blob output documentation: configuration table reorganized, many keys renamed or added (including emulator-related fields), defaults adjusted (e.g., auto_create_container), and examples updated to use consistent naming and corrected references to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pipeline/outputs/azure_blob.md`:
- Line 26: The description for the `blob_uri_length` setting incorrectly
references "ingesting to Azure Kusto"—update the text to describe Azure Blob
behavior instead: state that `blob_uri_length` controls the length of the
generated blob URI (or blob name/object key) used when creating/uploading
objects to Azure Blob Storage, and that the default is `64`; modify the
`blob_uri_length` entry in the table to replace the Kusto reference with this
accurate Azure Blob description.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 02e3c8f7-dcb8-492c-8c41-af346c09291c
📒 Files selected for processing (1)
pipeline/outputs/azure_blob.md
- Fix blob_uri_length description - Fix table column alignment on azure_blob_buffer_key and blob_uri_length rows (off by one space) Applies to fluent#2412 Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
@cosmo0920 and @patrick-stephens ready for review! |
Applies to #2412
Summary by CodeRabbit