Skip to content

Conversation

@konstantin-petrukhnov-ge
Copy link
Contributor

@konstantin-petrukhnov-ge konstantin-petrukhnov-ge commented Dec 30, 2025

COR-3430 - replace Bulgaria currency to EUR

Summary by CodeRabbit

  • Updates

    • Bulgaria's currency changed from BGN to EUR across country and regional data; region language and country-code entries updated accordingly.
    • Package version bumped to 0.1.19.
  • Chores

    • IDE/project metadata added to the ignore list.
    • Minor formatting/EOF newline fixes across data files.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2025

📝 Walkthrough

Walkthrough

Adds .idea to .gitignore, updates Bulgaria's currency from BGN to EUR across country and region data, adds related country/language codes in region aggregates, bumps package version, and adds trailing newlines to several data files.

Changes

Cohort / File(s) Summary
Build & Configuration
\.gitignore, package.json
Added .idea to ignore list; bumped package version from 0.1.18 to 0.1.19.
Data — Regions & Aggregates
data/regions.json
Changed Bulgaria-related currency entries from BGN to EUR; added country code BGR to multiple region country lists and language code bg to Europe; minor EOF/whitespace newline added.
Data — Countries
data/countries.json
Bulgaria's default_currency changed from BGN to EUR; added trailing newline.
Data — Misc
data/payment-methods.json
Trailing newline added (no data/content changes).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing Bulgaria's currency from BGN to EUR, which is reflected across multiple files (countries.json and regions.json).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b976479 and 4449ec2.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • data/payment-methods.json
  • data/regions.json
  • package.json
✅ Files skipped from review due to trivial changes (2)
  • data/payment-methods.json
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • data/regions.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Jenkins

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
data/regions.json (1)

878-893: Correct Bulgaria's currency from EUR to BGN.

Bulgaria's official currency is the Bulgarian Lev (BGN) as of December 2025. The Euro adoption is scheduled for 1 January 2026, not now. The current code lists EUR, which is incorrect for the present date and will cause:

  • Incorrect currency conversions and pricing for Bulgarian users
  • Financial transaction errors
  • Compliance issues

Change line 884 from "EUR" to "BGN" in the Bulgaria region entry. If preparing for the 1 January 2026 adoption, this change should be feature-flagged or scheduled to activate on that date.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f80206 and c2f43d3.

📒 Files selected for processing (2)
  • .gitignore
  • data/regions.json
🔇 Additional comments (2)
.gitignore (1)

48-48: LGTM!

Adding .idea to .gitignore is standard practice for excluding JetBrains IDE configuration files from version control.

data/regions.json (1)

5707-5707: Minor formatting adjustment.

The closing bracket formatting appears correct for the JSON array.

@konstantin-petrukhnov-ge konstantin-petrukhnov-ge changed the title [COR-3430] - replace Bulgaria currency to EUR COR-3430 - replace Bulgaria currency to EUR Dec 30, 2025
kangj-pluto
kangj-pluto previously approved these changes Dec 30, 2025
Copy link

@kangj-pluto kangj-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@prakhar-flow prakhar-flow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@konstantin-petrukhnov-ge konstantin-petrukhnov-ge merged commit f2c85ed into main Dec 31, 2025
6 checks passed
@konstantin-petrukhnov-ge konstantin-petrukhnov-ge deleted the COR-3430-bgn-to-eur branch December 31, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants