-
Notifications
You must be signed in to change notification settings - Fork 0
COR-3430 - replace Bulgaria currency to EUR #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
data/regions.json (1)
878-893: Correct Bulgaria's currency from EUR to BGN.Bulgaria's official currency is the Bulgarian Lev (BGN) as of December 2025. The Euro adoption is scheduled for 1 January 2026, not now. The current code lists EUR, which is incorrect for the present date and will cause:
- Incorrect currency conversions and pricing for Bulgarian users
- Financial transaction errors
- Compliance issues
Change line 884 from
"EUR"to"BGN"in the Bulgaria region entry. If preparing for the 1 January 2026 adoption, this change should be feature-flagged or scheduled to activate on that date.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.gitignoredata/regions.json
🔇 Additional comments (2)
.gitignore (1)
48-48: LGTM!Adding
.ideato.gitignoreis standard practice for excluding JetBrains IDE configuration files from version control.data/regions.json (1)
5707-5707: Minor formatting adjustment.The closing bracket formatting appears correct for the JSON array.
kangj-pluto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
prakhar-flow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
COR-3430 - replace Bulgaria currency to EUR
Summary by CodeRabbit
Updates
Chores
✏️ Tip: You can customize this high-level summary in your review settings.