FDN-4252: adding NPM token with bypass 2FA option and whitelisted IPs

[arias-m]

Summary by CodeRabbit

• Chores
  • Updated build infrastructure configuration for improved deployment reliability.

---

Note: This release contains no user-facing changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Jenkinsfile modified to swap NPM authentication token credential source from jenkins-npm-automation-token to jenkins-npm-bypass-2fa-token in two locations: the environment block and the Lint stage.

Changes

Cohort / File(s)	Summary
NPM authentication token credential update Jenkinsfile	NPM registry authentication credential ID changed from jenkins-npm-automation-token to jenkins-npm-bypass-2fa-token in top-level environment block and Lint stage

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single file affected with straightforward credential ID substitution
• Homogeneous change pattern (same swap applied twice)
• No logic, functional, or structural modifications

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references adding an NPM token with bypass 2FA, but the actual change only swaps which existing token is used in the Jenkinsfile, not the addition of a new capability.	Update the title to accurately reflect the change, such as 'FDN-4252: Swap NPM authentication token to bypass 2FA version' or similar, to better describe what the PR actually does.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Jenkinsfile (1)

36-40: Consider removing redundant environment variable definition.

The NPM_TOKEN is defined at both the pipeline level (line 22) and the Lint stage level (line 38), with the stage-level definition shadowing the pipeline-level one. If NPM_TOKEN is only needed within the Lint stage, consolidate by removing the pipeline-level definition to reduce redundancy and improve clarity.

If the pipeline-level definition is intentionally kept as a fallback for potential future stages, consider adding an inline comment explaining this pattern.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e4eeff and 0caee90.

📒 Files selected for processing (1)

• Jenkinsfile (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Jenkins

🔇 Additional comments (1)

Jenkinsfile (1)

20-23: Verify the new Jenkins credential exists and is accessible.

The NPM_TOKEN credential source has been swapped from jenkins-npm-automation-token to jenkins-npm-bypass-2fa-token. Ensure that the new credential is properly configured in Jenkins and accessible by this pipeline, and that any IP whitelisting configuration is in place as indicated in the PR title.