Repository navigation
feat(flow-php/etl): the run report shows the peak memory of every process - #2713
Merged
Merged
Conversation
…cess - Statistics::$memory is now $heap; the new $processes holds the OS peak of the parent and of every worker - SourceCounts is now RunCounts; launchers report worker peaks into it, with worker() and absorbWorkers() - the Report reads the memory and row count that TelemetryContext keeps; it no longer measures them again - Report::normalize() gives the JSON form for CI; INF and NaN are encoded, never dropped - column statistics: min and max skip NaN, as in Parquet and arrow-rs - the CLI prints heap, process, worker and summed peaks; analyze() warns when it stops parallel writes
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2713 +/- ##
============================================
+ Coverage 89.89% 90.50% +0.60%
- Complexity 290 31045 +30755
============================================
Files 2177 2178 +1
Lines 89673 89805 +132
============================================
+ Hits 80609 81274 +665
+ Misses 9064 8531 -533 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/etl-Statistics::$processeswith the OS peak memory of the parent and of every workerflow-php/etl-Report::normalize()for a JSON form of the run reportflow-php/etl- warning whenwithSchema()orwithColumnStatistics()stop parallel writesflow-php/cli- heap, process, worker and summed memory peaks in the run statisticsFixed
flow-php/etl- column statistics min and max skip NaNChanged
flow-php/etl-Statistics::$memoryrenamed to$heapflow-php/etl-SourceCountsrenamed toRunCounts, it also collects worker peaksflow-php/etl- the run report reads memory and row count from telemetry instead of measuring them twiceRemoved
Deprecated
Security