Repository navigation
feat(flow-php/etl): corrupted records are refused or routed, never repaired silently - #2712
Merged
Merged
Conversation
…paired silently - readers refuse records that don't match the header or schema with CorruptedRecordException - withCorruptedRecords($loader) routes them through the run's own loader lifecycle - withMissingColumnsAsNull() replaces padding, truncation and Google Sheet withDropExtraColumns() - schema errors for records or keys past the inference sample and missing declared columns - Rust CSV and JSON readers match the PHP readers - to_date_time(null) returns null; Corrupted Records documentation page
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2712 +/- ##
============================================
+ Coverage 90.18% 90.47% +0.29%
- Complexity 122 31012 +30890
============================================
Files 2175 2177 +2
Lines 89259 89673 +414
============================================
+ Hits 80499 81134 +635
+ Misses 8760 8539 -221 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/etl- CorruptedRecordException for a record that cannot become a rowflow-php/etl- withCorruptedRecords($loader) routes corrupted records to a loader (CorruptedRecordsRouter)flow-php/etl-adapter-csv- withMissingColumnsAsNull() pads short recordsflow-php/etl-adapter-excel- withMissingColumnsAsNull(), true by defaultflow-php/etl-adapter-google-sheet- withMissingColumnsAsNull() pads short rowsflow-php/flow-php-ext- native CSV and JSON readers report corrupted records like the PHP readersFixed
flow-php/etl-adapter-csv- extra fields of a line are no longer dropped silentlyflow-php/etl-adapter-excel- extra cells of a row are no longer dropped silentlyflow-php/etl-adapter-json- a key first seen after the inference sample is a schema error, not droppedflow-php/etl-adapter-csv- a declared column missing from the header is a schema error, not nullChanged
flow-php/etl- a value that does not cast to a declared schema is a corrupted recordflow-php/etl- a record past the inference sample throws InferredSchemaException with its offset and lineflow-php/etl- extract() may yield CorruptedRecordException beside Rowsflow-php/etl- to_date_time(null) returns nullflow-php/etl-adapter-csv- an empty line is skippedflow-php/etl-adapter-json- JsonReadBytes renamed to JsonReadProgressRemoved
flow-php/etl-adapter-google-sheet- withDropExtraColumns()Deprecated
Security