Repository navigation
feat(flow-php/filesystem): exclusive create, local permissions, non-recursive rm - #2711
Merged
Merged
Conversation
…ecursive rm - Filesystem::create() makes a file visible whole at close() and throws FileExistsException when the path exists - S3 and Azure create() commit with If-None-Match; an S3 conflicting write aborts and asks to create again; SFTP and StdOut refuse it - Local\Permissions for files and directories on NativeLocalFilesystem and the block factory - rm() takes $recursive; false refuses a non-empty directory - mv() no longer warns or leaves a directory for a missing source, and replaces files atomically - fixed Azure blocks visible before close(), azure-sdk deleteContainer(), and a stray S3 key on empty append
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2711 +/- ##
============================================
+ Coverage 90.40% 90.44% +0.04%
- Complexity 0 30909 +30909
============================================
Files 2174 2175 +1
Lines 89093 89259 +166
============================================
+ Hits 80543 80729 +186
+ Misses 8550 8530 -20 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/filesystem-Filesystem::create()exclusive create, visible at close, throwsFileExistsExceptionflow-php/filesystem-Local\Permissionsfor local files, directories and block filesflow-php/filesystem-async-aws-bridge- exclusivecreate()withIf-None-Matchflow-php/filesystem-azure-bridge- exclusivecreate()withIf-None-Matchflow-php/azure-sdk-withIfNoneMatch()on block blob put optionsFixed
flow-php/filesystem-mv()warning and leftover directory on a missing sourceflow-php/filesystem-azure-bridge- empty blob visible beforeclose()on multi-block writesflow-php/filesystem-async-aws-bridge- stray key on an empty appendflow-php/azure-sdk-deleteContainer()missingrestype=containerChanged
flow-php/filesystem-rm()takes$recursive, false refuses a non-empty directoryflow-php/filesystem-mv()replaces files atomically instead of delete then renameRemoved
Deprecated
Security