Skip to content

Fix SplObjectStorage PHP 8.5 deprecations#2371

Closed
jdecool wants to merge 0 commit into
flow-php:1.xfrom
jdecool:1.x-fix-php85-depreciations
Closed

Fix SplObjectStorage PHP 8.5 deprecations#2371
jdecool wants to merge 0 commit into
flow-php:1.xfrom
jdecool:1.x-fix-php85-depreciations

Conversation

@jdecool
Copy link
Copy Markdown

@jdecool jdecool commented May 19, 2026

Change Log


Added

Fixed

Changed

Removed

Deprecated

  • Fix `SplObjectStorage` PHP 8.5 deprecations

Security


Description

When running flow on a server with PHP 8.5, I've some deprecations like:

PHP Deprecated: Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead in /Users/jdecool/Workspace/sandbox/flow-php/vendor/flow-php/flow/src/core/etl/src/Flow/ETL/Pipeline/Segment.php on line 29

So, this PR fix them.

@jdecool jdecool requested a review from norberttech as a code owner May 19, 2026 18:39
@jdecool jdecool force-pushed the 1.x-fix-php85-depreciations branch 3 times, most recently from dfa31b5 to 8d16251 Compare May 19, 2026 18:47
@jdecool jdecool closed this May 19, 2026
@jdecool jdecool force-pushed the 1.x-fix-php85-depreciations branch from 8d16251 to f645b1e Compare May 19, 2026 18:47
@norberttech
Copy link
Copy Markdown
Member

@jdecool I believe I fixed it with merge yesterday related to covering project with mago analyzer

@jdecool jdecool deleted the 1.x-fix-php85-depreciations branch May 20, 2026 06:13
@jdecool
Copy link
Copy Markdown
Author

jdecool commented May 20, 2026

Yes. I've made this MR few days ago, but I published it yesterday.

So I didn't notice the change before. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants