I added multidimensionality functions to the tvrdiff method by callin…#188
Open
mariaprot wants to merge 1 commit intoflorisvb:masterfrom
Open
I added multidimensionality functions to the tvrdiff method by callin…#188mariaprot wants to merge 1 commit intoflorisvb:masterfrom
mariaprot wants to merge 1 commit intoflorisvb:masterfrom
Conversation
…g it recursively. Some changes might need to be made in terms of making the code less verbose, in particular, replacing moveaxis() with apply_along_axis()
pavelkomarov
requested changes
Feb 20, 2026
| return x_hat, dxdt_hat | ||
|
|
||
| #N-d case: | ||
| def tvrdiff(x, dt, order, gamma, huberM=float('inf'), solver=None, axis=0): |
Collaborator
There was a problem hiding this comment.
Let's keep only one public-facing function. If there needs to be a 1d function, you can indent it and put it inside the outer one.
| - **dxdt_hat** (np.array) -- estimated derivative of x | ||
| """ | ||
|
|
||
| x0 = np.moveaxis(x, axis, 0) |
Collaborator
There was a problem hiding this comment.
instead of np.moveaxis with creating a new data array, I think np.apply_along_axis is more automatic and shorter. Strive to do things in as few calls as possible, because each addition becomes something more to parse when people read and manage the code later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g it recursively. Some changes might need to be made in terms of making the code less verbose, in particular, replacing moveaxis() with apply_along_axis()