fix: add Props types to Carousel to satisfy astro check - #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI failure on master. PR #173 (restore carousel) and PR #174 (add
astro checkto CI) were each green on their own branches, but conflict semantically: the carousel's untypeditemsprop produces four implicit-anyerrors (ts(7006)) underastro check, which broke CI once both merged.This adds a
Propsinterface toCarousel.astrotypingitemsas{ src: string; header: string }[](matching thevscodeSlidesdata inindex.astro) andclassas an optional string.Testing
npm run check— 0 errors, 0 warnings, 0 hints (was 4 errors)npm run build— completes cleanly, all 10 pages generated🤖 Generated with Claude Code