Add shared haptics helper and mobile vibration fallback in api/xr.js#353
Open
tracygardner wants to merge 2 commits intomainfrom
Open
Add shared haptics helper and mobile vibration fallback in api/xr.js#353tracygardner wants to merge 2 commits intomainfrom
tracygardner wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
api/xr.js.Description
triggerHapticsthat attempts gamepad haptics viavibrationActuator.playEffect("dual-rumble", ...)first, and falls back tonavigator.vibrate(...)if no suitable actuator is found.controllerRumbleto calltriggerHapticsand map mobile behavior to a single vibration duration (ignoring left/right motors on phones).controllerRumblePatternto build scheduled gamepadeffectsand a corresponding vibration array ([on, off, on, off, ...]) for the mobile fallback.playRumblePatternto convert entries inrumblePatterns(using each pulse'sdurationandpauseAfter) into both gamepad effects and a vibration-array timing fornavigator.vibrate, while keeping behavior noop-safe when neither API is available.Testing
node --check api/xr.jswhich completed without errors.Codex Task