Skip to content

Fix ECS module publishing schema fields #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mabadir merged 1 commit into from
Jun 19, 2026
Merged

Fix ECS module publishing schema fields #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compute/ecs_service/rvn-ecs-web-definition.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ definition:
name: ECS Web Server
description: Web server ECS service for running an HTTP application behind an ECS cluster load balancer.
release:
version: 0.6.0
version: 0.6.1
description: Add native ECS blue/green, linear, and canary deployments with per-deploy strategy controls, manual approval gates, standby validation traffic, production/alternate target groups, ALB group stickiness guidance, ECS infrastructure role, and load-balancer advanced configuration outputs.
Comment on lines +6 to 7

@greptile-apps greptile-apps Bot Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The release.description was not updated to describe the 0.6.1 changes. Per the AGENTS.md guidelines, release.description should summarize the publishable change for the new version, not carry forward the 0.6.0 feature narrative. The current text describes the blue/green/canary features added in 0.6.0; the 0.6.1 patch fixes the publishing schema (item_title and singular ecs_service_arn).

Suggested change
version: 0.6.1
description: Add native ECS blue/green, linear, and canary deployments with per-deploy strategy controls, manual approval gates, standby validation traffic, production/alternate target groups, ALB group stickiness guidance, ECS infrastructure role, and load-balancer advanced configuration outputs.
version: 0.6.1
description: Fix publishing schema by replacing unsupported item_title_field with item_title.template and updating ecs_service_arn to the singular form required by the latest ECS deploy schema.
Prompt To Fix With AI 
This is a comment left during a code review.
Path: compute/ecs_service/rvn-ecs-web-definition.yml
Line: 6-7

Comment:
The `release.description` was not updated to describe the 0.6.1 changes. Per the AGENTS.md guidelines, `release.description` should summarize the publishable change for the new version, not carry forward the 0.6.0 feature narrative. The current text describes the blue/green/canary features added in 0.6.0; the 0.6.1 patch fixes the publishing schema (`item_title` and singular `ecs_service_arn`).

```suggestion
  version: 0.6.1
  description: Fix publishing schema by replacing unsupported item_title_field with item_title.template and updating ecs_service_arn to the singular form required by the latest ECS deploy schema.
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

module:
inputs:
Expand Down Expand Up @@ -164,7 +164,8 @@ module:
description: Proceed with the deployment as if it were approved.
value: CONTINUE
item_label: Pause stage
item_title_field: stage
item_title:
template: "{stage}"
item_description: "Timeout: {timeout_in_minutes} minutes / {timeout_action}"
show_when:
deployment_strategy:
Expand Down Expand Up @@ -418,8 +419,7 @@ module:
>>
infrastructure:
ecs_cluster_arn: <<stack.output.service_cluster>>
ecs_service_arns:
- <<stack.output.service_arn>>
ecs_service_arn: <<stack.output.service_arn>>
ecs_target_group_arn: <<stack.output.target_group_arn>>
# Load-balancer advanced configuration for native traffic-shift
# strategies (blue_green / linear / canary). The deploy manager
Expand Down
Loading