Skip to content

Add ability to bypass profiling entirely by making ProfilingSettings optional - #1681

Open
elliottslaughter wants to merge 1 commit into
flexflow:masterfrom
elliottslaughter:profiling-bypass
Open

Add ability to bypass profiling entirely by making ProfilingSettings optional#1681
elliottslaughter wants to merge 1 commit into
flexflow:masterfrom
elliottslaughter:profiling-bypass

Conversation

@elliottslaughter

@elliottslaughter elliottslaughter commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator
  • Most places now take std::optional<ProfilingSettings>
  • The meaning of std::nullopt in this case is "don't profile, just run the kernel exactly once"
  • The reason to bypass profiling is that, for GPU tasks, profiling forces a wait on the GPU stream, which is unacceptable in production code
  • Specific cases:
    • local-execution: profiling is optional
    • cost estimator: profiling is mandatory
    • realm-execution: profiling has been removed entirely; we never actually reported the results and Realm has better ways of profiling that don't involve blocking

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant