ProfilingSettings takes a nonnegative_int and a positive_int - #1679
Closed
elliottslaughter wants to merge 1 commit into
Closed
ProfilingSettings takes a nonnegative_int and a positive_int#1679elliottslaughter wants to merge 1 commit into
elliottslaughter wants to merge 1 commit into
Conversation
lockshaw
pushed a commit
that referenced
this pull request
Sep 5, 2026
#1679) This adds constraints on ProfilingSettings by typing the fields more accurately to nonnegative_int and positive_int respectively. Previously we had a lot of tests that simply weren't running due to passing zero for both parameters.
Collaborator
|
Merged in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloning from #1657 because GitHub is weird and doesn't seem to be updating to my changes.
This currently fails with:
Which is not going to be resolved until #1667 merges.
This change is