Shut off NCCL when using only 1 device - #1678
Open
elliottslaughter wants to merge 1 commit into
Open
Conversation
elliottslaughter
force-pushed
the
nccl-single-device
branch
from
September 8, 2026 21:54
d1550b9 to
bfaf8c3
Compare
elliottslaughter
force-pushed
the
nccl-single-device
branch
from
September 9, 2026 16:13
bfaf8c3 to
fc676ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of hack: when we only have 1 device, initializing NCCL wastes about half a GB of memory that we can use for something else. This reclaims that space by shutting off NCCL in that situation.
This change is