Skip to content

Use the largest device memory available under Realm #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elliottslaughter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use the largest device memory available under Realm #1675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/realm-execution/src/realm-execution/dynamic_tensor_accessor_from_instance.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ static DeviceType infer_device_type_from_memory_and_processor(
device_type = DeviceType::CPU;
break;
case Realm::Memory::GPU_FB_MEM:
case Realm::Memory::GPU_DYNAMIC_MEM:
// Only accessible on GPU
device_type = DeviceType::GPU;
break;
Expand Down
15 changes: 12 additions & 3 deletions lib/realm-execution/src/realm-execution/realm_context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,21 @@ Realm::Memory RealmContext::get_nearest_memory(Realm::Processor proc) {
return Realm::Memory::NO_MEMORY;
}

// FIMXE: this isn't going to do what you expect until
// https://github.com/StanfordLegion/realm/pull/392 merges
Realm::Machine::MemoryQuery mq(Realm::Machine::get_machine());
mq.best_affinity_to(proc);
ASSERT(mq.count() > 0);
return mq.first();

// Among the best memories, pick the one with the largest capacity
Realm::Memory result = Realm::Memory::NO_MEMORY;
for (Realm::Machine::MemoryQuery::iterator it = mq.begin(); it != mq.end();
++it) {
if (!result.exists() || it->capacity() > result.capacity()) {
result = *it;
}
}

ASSERT(result.exists());
return result;
}

Realm::Processor RealmContext::get_current_processor() const {
Expand Down
Loading