Add DynamicOpenDataflowGraph acceleration data structures - #1671
Draft
elliottslaughter wants to merge 6 commits into
Draft
Add DynamicOpenDataflowGraph acceleration data structures#1671elliottslaughter wants to merge 6 commits into
elliottslaughter wants to merge 6 commits into
Conversation
elliottslaughter
force-pushed
the
dodg-value-lookup
branch
from
September 3, 2026 17:28
fe35021 to
c9bdcc1
Compare
elliottslaughter
force-pushed
the
dodg-value-lookup
branch
from
September 8, 2026 21:53
c9bdcc1 to
9f42106
Compare
elliottslaughter
force-pushed
the
dodg-value-lookup
branch
from
September 9, 2026 16:13
9f42106 to
cbf95ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definitely not in a final state yet, but sending this draft PR to show what I'm doing to accelerate the
DynamicOpenDataflowGraphvalue lookup data structures.TODO:
DynamicOpenDataflowGraphas a proper class and encapsulate its implementationNotes to self:
set/mapare ferociously slow due to large keys (DynamicNodeInvocation/DynamicValueAttrs). This is, strictly speaking, a constant factor, but it's massive: > 10x in some cases. The larger and more important issues are reducing the number of calls tooperator<via better algorithms, but it's worth keeping in mind that e.g., a naivebidict<dynamic_node_invocation_id_t, DynamicNodeInvocation>is by itself a 6x slowdown if you aren't careful.This change is