Rename geometry workflow API to Catalyst#1978
Rename geometry workflow API to Catalyst#1978maciej-flexcompute wants to merge 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9bf84bc. Configure here.
| use_catalyst: bool = pd_v2.Field( | ||
| default=False, | ||
| alias="useNextflow", | ||
| description="Route geometry processing through Nextflow pipeline instead of legacy system", |
There was a problem hiding this comment.
Missing REST alias changes serialized payload field name
High Severity
The old use_nextflow field had an explicit alias="useNextflow" which ensured the REST API payload used the key useNextflow. The rename to use_catalyst removed this explicit alias, so the alias_generator=to_camel on Flow360RequestsV2 now produces useCatalyst instead. Since dict() calls model_dump(by_alias=True), the serialized payload key has silently changed from useNextflow to useCatalyst. The PR description explicitly states the intent to "keep the existing REST compatibility field at the serialization boundary," which means the field needs alias="useNextflow" to preserve backend compatibility. Without it, the backend will not recognize the new key and the Catalyst workflow will never activate.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 9bf84bc. Configure here.
There was a problem hiding this comment.
@maciej-flexcompute This is going to be handled by the Java alias I think..? Although if we are changing the names here, we could probably just drop the old name in the Java API as well?
| use_catalyst: bool = pd_v2.Field( | ||
| default=False, | ||
| alias="useNextflow", | ||
| description="Route geometry processing through Nextflow pipeline instead of legacy system", |
There was a problem hiding this comment.
@maciej-flexcompute This is going to be handled by the Java alias I think..? Although if we are changing the names here, we could probably just drop the old name in the Java API as well?


Summary
Testing
Note
Medium Risk
Moderate risk because it changes the public geometry/project creation API and the serialized request field sent to the backend; incorrect mapping could route geometry processing through the wrong pipeline.
Overview
Renames the geometry-processing pipeline switch from Nextflow wording to a
workflowselector. Geometry/project creation now acceptsworkflow="standard"|"catalyst"(defaultstandard) instead of the prior boolean flag, with added validation.Updates the REST payload mapping and adds regression tests.
GeometryDraftserializesworkflow="catalyst"touseCatalyst=trueinNewGeometryRequest, andProject.from_geometry()passes the workflow through; new tests cover both passthrough and correct API payload forstandardvscatalyst.Reviewed by Cursor Bugbot for commit 9bf84bc. Bugbot is set up for automated code reviews on this repo. Configure here.