[FXC-5886] Remap symmetry plane to user geometry#1947
Open
alexxu-flex wants to merge 18 commits intomainfrom
Open
[FXC-5886] Remap symmetry plane to user geometry#1947alexxu-flex wants to merge 18 commits intomainfrom
alexxu-flex wants to merge 18 commits intomainfrom
Conversation
…oundary_entities; +6 unit tests
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0eb215e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

For half-body user defined farfield, allow the user to reference geometry["symmetry"] directly, instead of "farfield.symmetry_plane", when applicable.
Changes:
_will_be_deleted_by_mesherto no longer delete for UDFremap_symmetric_ghost_entityto replace ghost symmetry surface (both BC entity and ghost asset) with Surface(user's name). Called wherever symmetry_plane can be used (BoundaryBase, Refinement)_collect_asset_boundary_entitiesif user has any symmetry surfacesMinor changes: shared
find_user_symmetry_surfacesutil, fix test json with center y!=0, rename _overlaps -> _lies_on, test_auto_farfield -> test_farfieldTesting: 7+ new unit tests, several existing unit tests, and a few integration tests confirm backwards compatibility and new interface both work correctly.
Note
Medium Risk
Changes core validation and boundary-collection behavior around symmetry surfaces for user-defined farfield, which could affect what entities are considered valid and how meshes are generated. Risk is mitigated by added unit tests but touches multiple validation paths and entity mutation.
Overview
Enables user-defined farfield half-body cases (GAI + beta mesher) to prefer an explicit y=0 geometry face over the legacy
farfield.symmetry_planeghost by remapping any referenced"symmetric"ghost entity to the single detected user symmetrySurface(and updating the cached ghost entity metadata to match).Updates mesher-deletion/validation rules so user-defined farfield surfaces are not treated as deletable (except for being on the wrong half), avoids adding the
"symmetric"ghost boundary when a user symmetry face exists, and adds a validation warning when multiple y=0 symmetry faces have conflicting BC types; includes doc/test fixture updates and several new unit tests covering remap/no-remap and multi-patch behavior.Reviewed by Cursor Bugbot for commit 0eb215e. Bugbot is set up for automated code reviews on this repo. Configure here.