Release 1.4.1 - #18
Merged
Merged
Conversation
1.4.0 shipped before the upstream rename landed, so this is a patch on top of it rather than a change to a published release. A submission answers with `answers`, each entry naming its `field` by the public id the form hands out; `custom_field_values` and `custom_field` are still accepted on submit, so nothing integrating against an older deployment breaks. The SDK forwards a submission body verbatim, so no src/ file names these keys. This repins the locked contract at the merged collection and regenerates what follows from it, and updates the hand-written pieces: the README example, the test payload and response fixtures, the dated changelog section and the release note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks the inspection API's renamed submission answers, which landed upstream after 1.4.0 was published.
Supersedes #17, which was cut as
release/1.4.0before I checked the tags. 1.4.0 is already released — tagged atf8237cc, which ismain's HEAD, published on GitHub and live on Packagist — sorelease.ymlwould derive version 1.4.0 from the branch name andcheck-release-version.phpwould refuse the tag as already existing. CI caught this too: #17's "Release candidate dry run" failed at Validate release identity and dependency security, while every other check passed. This is a patch on top of 1.4.0, so it is 1.4.1.What changed
A submission's answers were
custom_field_values, each naming its field withcustom_field. The API calls themanswersandfieldnow — that is what it documents and what it returns — and a field is named by a public id rather than a bare uuid. The earlier spellings are still accepted on submit, so this is additive and breaks no existing integration.The SDK forwards a submission body verbatim, so no
src/file names any of these keys and none needed rewriting. What changed is the locked contract and everything generated from it, plus the hand-written pieces: the README example, the submission test's payload and response fixtures, the dated changelog section anddocs/releases/1.4.1.md.The generated submit example previously sent an empty
custom_field_valuesbeside a populated flatitem_resultsblock — the only worked example in the reference was the legacy shape. It now answers the way the API documents.Pins
postman→822b867(the collection rename and its response examples, both merged)fleetops→refs/pull/319/head@9f2ffe98As in 1.4.0, the upstream implementation is still Fleet-Ops PR #319; release approval must confirm its API is available in the intended deployment. A passing overlay run proves the locked implementation, not availability in every published image.
Checks
composer checkpasses locally: PHPStan clean, PHPUnit 41 tests / 4749 assertions, contract manifest 270 requests with 270 mapped and 0 unmapped, 38 service groups, 270 executable examples, licence metadata verified, and API compatibility confirmed against 1.0.2, 1.0.3, 1.1.0, 1.2.0 and 1.3.0.php tools/check-release-version.php 1.4.1reports Release version 1.4.1 verified against latest tag 1.4.0.On #17 the live Postman/SDK contract passed (11m17s) with
"answers": []in the asserted response, so the rename is verified end to end through the SDK bridge.docs/api-coverage.mdshows every row changed: each embeds the locked Postman commit in its source links, so repinning rewrites all 270 lines. The request set, services and statuses are unchanged.